suricata
detect-icode.c
Go to the documentation of this file.
1 /* Copyright (C) 2007-2021 Open Information Security Foundation
2  *
3  * You can copy, redistribute or modify this Program under the terms of
4  * the GNU General Public License version 2 as published by the Free
5  * Software Foundation.
6  *
7  * This program is distributed in the hope that it will be useful,
8  * but WITHOUT ANY WARRANTY; without even the implied warranty of
9  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10  * GNU General Public License for more details.
11  *
12  * You should have received a copy of the GNU General Public License
13  * version 2 along with this program; if not, write to the Free Software
14  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
15  * 02110-1301, USA.
16  */
17 
18 /**
19  * \file
20  *
21  * \author Gerardo Iglesias <iglesiasg@gmail.com>
22  *
23  * Implements icode keyword support
24  */
25 
26 #include "suricata-common.h"
27 #include "decode.h"
28 
29 #include "detect.h"
30 #include "detect-parse.h"
32 #include "detect-engine-uint.h"
33 #include "detect-engine-build.h"
34 
35 #include "detect-icode.h"
36 
37 #include "util-byte.h"
38 #include "util-unittest.h"
39 #include "util-unittest-helper.h"
40 #include "util-debug.h"
41 
42 /**
43  *\brief Regex for parsing our icode options
44  */
45 
46 static int DetectICodeMatch(DetectEngineThreadCtx *, Packet *,
47  const Signature *, const SigMatchCtx *);
48 static int DetectICodeSetup(DetectEngineCtx *, Signature *, const char *);
49 #ifdef UNITTESTS
50 static void DetectICodeRegisterTests(void);
51 #endif
52 void DetectICodeFree(DetectEngineCtx *, void *);
53 
54 static int PrefilterSetupICode(DetectEngineCtx *de_ctx, SigGroupHead *sgh);
55 static bool PrefilterICodeIsPrefilterable(const Signature *s);
56 
57 /**
58  * \brief Registration function for icode: keyword
59  */
61 {
62  sigmatch_table[DETECT_ICODE].name = "icode";
63  sigmatch_table[DETECT_ICODE].desc = "match on specific ICMP id-value";
64  sigmatch_table[DETECT_ICODE].url = "/rules/header-keywords.html#icode";
65  sigmatch_table[DETECT_ICODE].Match = DetectICodeMatch;
66  sigmatch_table[DETECT_ICODE].Setup = DetectICodeSetup;
68 #ifdef UNITTESTS
69  sigmatch_table[DETECT_ICODE].RegisterTests = DetectICodeRegisterTests;
70 #endif
71  sigmatch_table[DETECT_ICODE].SupportsPrefilter = PrefilterICodeIsPrefilterable;
72  sigmatch_table[DETECT_ICODE].SetupPrefilter = PrefilterSetupICode;
74 }
75 
76 /**
77  * \brief This function is used to match icode rule option set on a packet with those passed via
78  * icode:
79  *
80  * \param t pointer to thread vars
81  * \param det_ctx pointer to the pattern matcher thread
82  * \param p pointer to the current packet
83  * \param ctx pointer to the sigmatch that we will cast into DetectU8Data
84  *
85  * \retval 0 no match
86  * \retval 1 match
87  */
88 static int DetectICodeMatch (DetectEngineThreadCtx *det_ctx, Packet *p,
89  const Signature *s, const SigMatchCtx *ctx)
90 {
92 
93  uint8_t picode;
94  if (PacketIsICMPv4(p)) {
95  picode = p->icmp_s.code;
96  } else if (PacketIsICMPv6(p)) {
97  const ICMPV6Hdr *icmpv6h = PacketGetICMPv6(p);
98  picode = ICMPV6_GET_CODE(icmpv6h);
99  } else {
100  /* Packet not ICMPv4 nor ICMPv6 */
101  return 0;
102  }
103 
104  const DetectU8Data *icd = (const DetectU8Data *)ctx;
105  return DetectU8Match(picode, icd);
106 }
107 
108 /**
109  * \brief this function is used to add the parsed icode data into the current signature
110  *
111  * \param de_ctx pointer to the Detection Engine Context
112  * \param s pointer to the Current Signature
113  * \param icodestr pointer to the user provided icode options
114  *
115  * \retval 0 on Success
116  * \retval -1 on Failure
117  */
118 static int DetectICodeSetup(DetectEngineCtx *de_ctx, Signature *s, const char *icodestr)
119 {
120 
121  DetectU8Data *icd = NULL;
122 
123  icd = DetectU8Parse(icodestr);
124  if (icd == NULL)
125  return -1;
126 
128  de_ctx, s, DETECT_ICODE, (SigMatchCtx *)icd, DETECT_SM_LIST_MATCH) == NULL) {
129  SCDetectU8Free(icd);
130  return -1;
131  }
133 
134  return 0;
135 }
136 
137 /**
138  * \brief this function will free memory associated with DetectU8Data
139  *
140  * \param ptr pointer to DetectU8Data
141  */
143 {
144  SCDetectU8Free(ptr);
145 }
146 
147 /* prefilter code */
148 
149 static void PrefilterPacketICodeMatch(DetectEngineThreadCtx *det_ctx,
150  Packet *p, const void *pectx)
151 {
153 
154  uint8_t picode;
155  if (PacketIsICMPv4(p)) {
156  picode = p->icmp_s.code;
157  } else if (PacketIsICMPv6(p)) {
158  const ICMPV6Hdr *icmpv6h = PacketGetICMPv6(p);
159  picode = ICMPV6_GET_CODE(icmpv6h);
160  } else {
161  /* Packet not ICMPv4 nor ICMPv6 */
162  return;
163  }
164 
165  const PrefilterPacketU8HashCtx *h = pectx;
166  const SigsArray *sa = h->array[picode];
167  if (sa) {
168  PrefilterAddSids(&det_ctx->pmq, sa->sigs, sa->cnt);
169  }
170 }
171 
172 static int PrefilterSetupICode(DetectEngineCtx *de_ctx, SigGroupHead *sgh)
173 {
175  PrefilterPacketU8Set, PrefilterPacketU8Compare, PrefilterPacketICodeMatch);
176 }
177 
178 static bool PrefilterICodeIsPrefilterable(const Signature *s)
179 {
180  return PrefilterIsPrefilterableById(s, DETECT_ICODE);
181 }
182 
183 #ifdef UNITTESTS
184 #include "detect-engine.h"
185 #include "detect-engine-mpm.h"
186 #include "detect-engine-alert.h"
187 
188 /**
189  * \test DetectICodeParseTest01 is a test for setting a valid icode value
190  */
191 static int DetectICodeParseTest01(void)
192 {
193  DetectU8Data *icd = DetectU8Parse("8");
194  FAIL_IF_NULL(icd);
195  FAIL_IF_NOT(icd->arg1 == 8);
196  FAIL_IF_NOT(icd->mode == DETECT_UINT_EQ);
197  DetectICodeFree(NULL, icd);
198 
199  PASS;
200 }
201 
202 /**
203  * \test DetectICodeParseTest02 is a test for setting a valid icode value
204  * with ">" operator
205  */
206 static int DetectICodeParseTest02(void)
207 {
208  DetectU8Data *icd = DetectU8Parse(">8");
209  FAIL_IF_NULL(icd);
210  FAIL_IF_NOT(icd->arg1 == 8);
211  FAIL_IF_NOT(icd->mode == DETECT_UINT_GT);
212  DetectICodeFree(NULL, icd);
213 
214  PASS;
215 }
216 
217 /**
218  * \test DetectICodeParseTest03 is a test for setting a valid icode value
219  * with "<" operator
220  */
221 static int DetectICodeParseTest03(void)
222 {
223  DetectU8Data *icd = DetectU8Parse("<8");
224  FAIL_IF_NULL(icd);
225  FAIL_IF_NOT(icd->arg1 == 8);
226  FAIL_IF_NOT(icd->mode == DETECT_UINT_LT);
227  DetectICodeFree(NULL, icd);
228 
229  PASS;
230 }
231 
232 /**
233  * \test DetectICodeParseTest04 is a test for setting a valid icode value
234  * with "<>" operator
235  */
236 static int DetectICodeParseTest04(void)
237 {
238  DetectU8Data *icd = DetectU8Parse("8<>20");
239  FAIL_IF_NULL(icd);
240  FAIL_IF_NOT(icd->arg1 == 8);
241  FAIL_IF_NOT(icd->arg2 == 20);
242  FAIL_IF_NOT(icd->mode == DETECT_UINT_RA);
243  DetectICodeFree(NULL, icd);
244 
245  PASS;
246 }
247 
248 /**
249  * \test DetectICodeParseTest05 is a test for setting a valid icode value
250  * with spaces all around
251  */
252 static int DetectICodeParseTest05(void)
253 {
254  DetectU8Data *icd = DetectU8Parse(" 8 ");
255  FAIL_IF_NULL(icd);
256  FAIL_IF_NOT(icd->arg1 == 8);
257  FAIL_IF_NOT(icd->mode == DETECT_UINT_EQ);
258  DetectICodeFree(NULL, icd);
259 
260  PASS;
261 }
262 
263 /**
264  * \test DetectICodeParseTest06 is a test for setting a valid icode value
265  * with ">" operator and spaces all around
266  */
267 static int DetectICodeParseTest06(void)
268 {
269  DetectU8Data *icd = DetectU8Parse(" > 8 ");
270  FAIL_IF_NULL(icd);
271  FAIL_IF_NOT(icd->arg1 == 8);
272  FAIL_IF_NOT(icd->mode == DETECT_UINT_GT);
273  DetectICodeFree(NULL, icd);
274 
275  PASS;
276 }
277 
278 /**
279  * \test DetectICodeParseTest07 is a test for setting a valid icode value
280  * with "<>" operator and spaces all around
281  */
282 static int DetectICodeParseTest07(void)
283 {
284  DetectU8Data *icd = DetectU8Parse(" 8 <> 20 ");
285  FAIL_IF_NULL(icd);
286  FAIL_IF_NOT(icd->arg1 == 8);
287  FAIL_IF_NOT(icd->arg2 == 20);
288  FAIL_IF_NOT(icd->mode == DETECT_UINT_RA);
289  DetectICodeFree(NULL, icd);
290 
291  PASS;
292 }
293 
294 /**
295  * \test DetectICodeParseTest08 is a test for setting an invalid icode value
296  */
297 static int DetectICodeParseTest08(void)
298 {
299  DetectU8Data *icd = DetectU8Parse("> 8 <> 20");
300  FAIL_IF_NOT_NULL(icd);
301 
302  PASS;
303 }
304 
305 /**
306  * \test DetectICodeParseTest09 is a test for setting an invalid icode value
307  * with "<<" operator
308  */
309 static int DetectICodeParseTest09(void)
310 {
311  DetectU8Data *icd = DetectU8Parse("8<<20");
312  FAIL_IF_NOT_NULL(icd);
313 
314  PASS;
315 }
316 
317 /**
318  * \test DetectICodeMatchTest01 is a test for checking the working of icode
319  * keyword by creating 5 rules and matching a crafted packet against
320  * them. 4 out of 5 rules shall trigger.
321  */
322 static int DetectICodeMatchTest01(void)
323 {
324  Signature *s = NULL;
325  ThreadVars th_v;
326  DetectEngineThreadCtx *det_ctx;
327 
328  memset(&th_v, 0, sizeof(th_v));
329  StatsThreadInit(&th_v.stats);
330 
331  Packet *p = UTHBuildPacket(NULL, 0, IPPROTO_ICMP);
332  FAIL_IF_NULL(p);
333  FAIL_IF_NOT(PacketIsICMPv4(p));
334  p->icmp_s.code = p->l4.hdrs.icmpv4h->code = 10;
335 
338 
339  de_ctx->flags |= DE_QUIET;
340 
341  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:10; sid:1;)");
342  FAIL_IF_NULL(s);
343 
344  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:<15; sid:2;)");
345  FAIL_IF_NULL(s);
346 
347  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:>20; sid:3;)");
348  FAIL_IF_NULL(s);
349 
350  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:8<>20; sid:4;)");
351  FAIL_IF_NULL(s);
352 
353  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:20<>8; sid:5;)");
354  FAIL_IF_NOT_NULL(s);
355 
357  DetectEngineThreadCtxInit(&th_v, (void *)de_ctx, (void *)&det_ctx);
358 
359  SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
360 
361  FAIL_IF(PacketAlertCheck(p, 1) == 0);
362  FAIL_IF(PacketAlertCheck(p, 2) == 0);
363  FAIL_IF(PacketAlertCheck(p, 3));
364  FAIL_IF(PacketAlertCheck(p, 4) == 0);
365 
366  DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx);
368 
369  UTHFreePackets(&p, 1);
370  StatsThreadCleanup(&th_v.stats);
371  PASS;
372 }
373 
374 /**
375  * \brief this function registers unit tests for DetectICode
376  */
377 void DetectICodeRegisterTests(void)
378 {
379  UtRegisterTest("DetectICodeParseTest01", DetectICodeParseTest01);
380  UtRegisterTest("DetectICodeParseTest02", DetectICodeParseTest02);
381  UtRegisterTest("DetectICodeParseTest03", DetectICodeParseTest03);
382  UtRegisterTest("DetectICodeParseTest04", DetectICodeParseTest04);
383  UtRegisterTest("DetectICodeParseTest05", DetectICodeParseTest05);
384  UtRegisterTest("DetectICodeParseTest06", DetectICodeParseTest06);
385  UtRegisterTest("DetectICodeParseTest07", DetectICodeParseTest07);
386  UtRegisterTest("DetectICodeParseTest08", DetectICodeParseTest08);
387  UtRegisterTest("DetectICodeParseTest09", DetectICodeParseTest09);
388  UtRegisterTest("DetectICodeMatchTest01", DetectICodeMatchTest01);
389 }
390 #endif /* UNITTESTS */
util-byte.h
detect-engine-uint.h
SigTableElmt_::url
const char * url
Definition: detect.h:1461
detect-engine.h
FAIL_IF_NULL
#define FAIL_IF_NULL(expr)
Fail a test if expression evaluates to NULL.
Definition: util-unittest.h:89
SIG_MASK_REQUIRE_REAL_PKT
#define SIG_MASK_REQUIRE_REAL_PKT
Definition: detect.h:316
SigTableElmt_::desc
const char * desc
Definition: detect.h:1460
sigmatch_table
SigTableElmt * sigmatch_table
Definition: detect-parse.c:79
SigTableElmt_::Free
void(* Free)(DetectEngineCtx *, void *)
Definition: detect.h:1445
SigTableElmt_::name
const char * name
Definition: detect.h:1458
PKT_IS_PSEUDOPKT
#define PKT_IS_PSEUDOPKT(p)
return 1 if the packet is a pseudo packet
Definition: decode.h:1323
SigGroupHead_
Container for matching data for a signature group.
Definition: detect.h:1628
UtRegisterTest
void UtRegisterTest(const char *name, int(*TestFn)(void))
Register unit test.
Definition: util-unittest.c:103
DETECT_UINT_LT
#define DETECT_UINT_LT
Definition: detect-engine-uint.h:37
SigTableElmt_::flags
uint32_t flags
Definition: detect.h:1449
PrefilterPacketU8HashCtx_::array
SigsArray * array[256]
Definition: detect-engine-prefilter-common.h:53
PacketAlertCheck
int PacketAlertCheck(Packet *p, uint32_t sid)
Check if a certain sid alerted, this is used in the test functions.
Definition: detect-engine-alert.c:142
DetectEngineThreadCtx_::pmq
PrefilterRuleStore pmq
Definition: detect.h:1348
ctx
struct Thresholds ctx
DetectEngineCtx_
main detection engine ctx
Definition: detect.h:933
DetectEngineCtxFree
void DetectEngineCtxFree(DetectEngineCtx *)
Free a DetectEngineCtx::
Definition: detect-engine.c:2634
DETECT_UINT_EQ
#define DETECT_UINT_EQ
Definition: detect-engine-uint.h:35
DE_QUIET
#define DE_QUIET
Definition: detect.h:330
UTHBuildPacket
Packet * UTHBuildPacket(uint8_t *payload, uint16_t payload_len, uint8_t ipproto)
UTHBuildPacket is a wrapper that build packets with default ip and port fields.
Definition: util-unittest-helper.c:365
SigMatchSignatures
void SigMatchSignatures(ThreadVars *tv, DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, Packet *p)
wrapper for old tests
Definition: detect.c:2418
Packet_::icmp_s
struct Packet_::@33::@40 icmp_s
SIGMATCH_SUPPORT_FIREWALL
#define SIGMATCH_SUPPORT_FIREWALL
Definition: detect.h:1681
DETECT_UINT_GT
#define DETECT_UINT_GT
Definition: detect-engine-uint.h:32
DetectEngineAppendSig
Signature * DetectEngineAppendSig(DetectEngineCtx *, const char *)
Parse and append a Signature into the Detection Engine Context signature list.
Definition: detect-parse.c:3447
SigTableElmt_::Setup
int(* Setup)(DetectEngineCtx *, Signature *, const char *)
Definition: detect.h:1440
util-unittest.h
util-unittest-helper.h
FAIL_IF_NOT
#define FAIL_IF_NOT(expr)
Fail a test if expression evaluates to false.
Definition: util-unittest.h:82
SigTableElmt_::SetupPrefilter
int(* SetupPrefilter)(DetectEngineCtx *de_ctx, struct SigGroupHead_ *sgh)
Definition: detect.h:1443
DetectU8Parse
DetectUintData_u8 * DetectU8Parse(const char *u8str)
This function is used to parse u8 options passed via some u8 keyword.
Definition: detect-engine-uint.c:85
decode.h
FAIL_IF_NOT_NULL
#define FAIL_IF_NOT_NULL(expr)
Fail a test if expression evaluates to non-NULL.
Definition: util-unittest.h:96
util-debug.h
PrefilterSetupPacketHeaderU8Hash
int PrefilterSetupPacketHeaderU8Hash(DetectEngineCtx *de_ctx, SigGroupHead *sgh, int sm_type, SignatureMask mask, void(*Set)(PrefilterPacketHeaderValue *v, void *), bool(*Compare)(PrefilterPacketHeaderValue v, void *), void(*Match)(DetectEngineThreadCtx *det_ctx, Packet *p, const void *pectx))
Definition: detect-engine-prefilter-common.c:462
PASS
#define PASS
Pass the test.
Definition: util-unittest.h:105
de_ctx
DetectEngineCtx * de_ctx
Definition: fuzz_siginit.c:19
DetectICodeRegister
void DetectICodeRegister(void)
Registration function for icode: keyword.
Definition: detect-icode.c:60
DetectEngineThreadCtx_
Definition: detect.h:1245
DETECT_ICODE
@ DETECT_ICODE
Definition: detect-engine-register.h:48
detect-engine-mpm.h
SCSigMatchAppendSMToList
SigMatch * SCSigMatchAppendSMToList(DetectEngineCtx *de_ctx, Signature *s, uint16_t type, SigMatchCtx *ctx, const int list)
Append a SigMatch to the list type.
Definition: detect-parse.c:388
detect.h
ThreadVars_
Per thread variable structure.
Definition: threadvars.h:58
DetectEngineThreadCtxInit
TmEcode DetectEngineThreadCtxInit(ThreadVars *tv, void *initdata, void **data)
initialize thread specific detection engine context
Definition: detect-engine.c:3364
DetectU8Data
DetectUintData_u8 DetectU8Data
Definition: detect-engine-uint.h:43
DETECT_SM_LIST_MATCH
@ DETECT_SM_LIST_MATCH
Definition: detect.h:117
PrefilterPacketU8Set
void PrefilterPacketU8Set(PrefilterPacketHeaderValue *v, void *smctx)
Definition: detect-engine-uint.c:90
PacketL4::L4Hdrs::icmpv4h
ICMPV4Hdr * icmpv4h
Definition: decode.h:471
Signature_::flags
uint32_t flags
Definition: detect.h:669
Packet_
Definition: decode.h:501
detect-engine-build.h
detect-engine-alert.h
Packet_::l4
struct PacketL4 l4
Definition: decode.h:601
ICMPV6_GET_CODE
#define ICMPV6_GET_CODE(icmp6h)
Definition: decode-icmpv6.h:103
SigTableElmt_::Match
int(* Match)(DetectEngineThreadCtx *, Packet *, const Signature *, const SigMatchCtx *)
Definition: detect.h:1420
SigGroupBuild
int SigGroupBuild(DetectEngineCtx *de_ctx)
Convert the signature list into the runtime match structure.
Definition: detect-engine-build.c:2194
StatsThreadInit
void StatsThreadInit(StatsThreadContext *stats)
Definition: counters.c:1249
SigMatchCtx_
Used to start a pointer to SigMatch context Should never be dereferenced without casting to something...
Definition: detect.h:351
ICMPV6Hdr_
Definition: decode-icmpv6.h:129
DetectU8Match
int DetectU8Match(const uint8_t parg, const DetectUintData_u8 *du8)
Definition: detect-engine-uint.c:71
FAIL_IF
#define FAIL_IF(expr)
Fail a test if expression evaluates to true.
Definition: util-unittest.h:71
SigsArray_::sigs
SigIntId * sigs
Definition: detect-engine-prefilter-common.h:47
DetectICodeFree
void DetectICodeFree(DetectEngineCtx *, void *)
this function will free memory associated with DetectU8Data
Definition: detect-icode.c:142
suricata-common.h
SigsArray_
Definition: detect-engine-prefilter-common.h:46
DetectEngineThreadCtxDeinit
TmEcode DetectEngineThreadCtxDeinit(ThreadVars *tv, void *data)
Definition: detect-engine.c:3601
SigsArray_::cnt
uint32_t cnt
Definition: detect-engine-prefilter-common.h:48
ICMPV4Hdr_::code
uint8_t code
Definition: decode-icmpv4.h:167
SigTableElmt_::SupportsPrefilter
bool(* SupportsPrefilter)(const Signature *s)
Definition: detect.h:1442
detect-parse.h
detect-icode.h
Signature_
Signature container.
Definition: detect.h:668
SIGMATCH_INFO_UINT8
#define SIGMATCH_INFO_UINT8
Definition: detect.h:1687
PacketL4::hdrs
union PacketL4::L4Hdrs hdrs
DetectEngineCtxInit
DetectEngineCtx * DetectEngineCtxInit(void)
Definition: detect-engine.c:2595
PrefilterPacketU8Compare
bool PrefilterPacketU8Compare(PrefilterPacketHeaderValue v, void *smctx)
Definition: detect-engine-uint.c:98
PrefilterPacketU8HashCtx_
Definition: detect-engine-prefilter-common.h:52
DetectEngineCtx_::flags
uint8_t flags
Definition: detect.h:935
detect-engine-prefilter-common.h
ThreadVars_::stats
StatsThreadContext stats
Definition: threadvars.h:121
StatsThreadCleanup
void StatsThreadCleanup(StatsThreadContext *stats)
Definition: counters.c:1345
DEBUG_VALIDATE_BUG_ON
#define DEBUG_VALIDATE_BUG_ON(exp)
Definition: util-validate.h:102
DETECT_UINT_RA
#define DETECT_UINT_RA
Definition: detect-engine-uint.h:34
SigTableElmt_::RegisterTests
void(* RegisterTests)(void)
Definition: detect.h:1447
SIG_FLAG_REQUIRE_PACKET
#define SIG_FLAG_REQUIRE_PACKET
Definition: detect.h:254
UTHFreePackets
void UTHFreePackets(Packet **p, int numpkts)
UTHFreePackets: function to release the allocated data from UTHBuildPacket and the packet itself.
Definition: util-unittest-helper.c:456