suricata
detect-icode.c
Go to the documentation of this file.
1 /* Copyright (C) 2007-2021 Open Information Security Foundation
2  *
3  * You can copy, redistribute or modify this Program under the terms of
4  * the GNU General Public License version 2 as published by the Free
5  * Software Foundation.
6  *
7  * This program is distributed in the hope that it will be useful,
8  * but WITHOUT ANY WARRANTY; without even the implied warranty of
9  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10  * GNU General Public License for more details.
11  *
12  * You should have received a copy of the GNU General Public License
13  * version 2 along with this program; if not, write to the Free Software
14  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
15  * 02110-1301, USA.
16  */
17 
18 /**
19  * \file
20  *
21  * \author Gerardo Iglesias <iglesiasg@gmail.com>
22  *
23  * Implements icode keyword support
24  */
25 
26 #include "suricata-common.h"
27 #include "decode.h"
28 
29 #include "detect.h"
30 #include "detect-parse.h"
32 #include "detect-engine-uint.h"
33 #include "detect-engine-build.h"
34 
35 #include "detect-icode.h"
36 
37 #include "util-byte.h"
38 #include "util-unittest.h"
39 #include "util-unittest-helper.h"
40 #include "util-debug.h"
41 
42 /**
43  *\brief Regex for parsing our icode options
44  */
45 
46 static int DetectICodeMatch(DetectEngineThreadCtx *, Packet *,
47  const Signature *, const SigMatchCtx *);
48 static int DetectICodeSetup(DetectEngineCtx *, Signature *, const char *);
49 #ifdef UNITTESTS
50 static void DetectICodeRegisterTests(void);
51 #endif
52 void DetectICodeFree(DetectEngineCtx *, void *);
53 
54 static int PrefilterSetupICode(DetectEngineCtx *de_ctx, SigGroupHead *sgh);
55 static bool PrefilterICodeIsPrefilterable(const Signature *s);
56 
57 /**
58  * \brief Registration function for icode: keyword
59  */
61 {
62  sigmatch_table[DETECT_ICODE].name = "icode";
63  sigmatch_table[DETECT_ICODE].desc = "match on specific ICMP id-value";
64  sigmatch_table[DETECT_ICODE].url = "/rules/header-keywords.html#icode";
65  sigmatch_table[DETECT_ICODE].Match = DetectICodeMatch;
66  sigmatch_table[DETECT_ICODE].Setup = DetectICodeSetup;
68 #ifdef UNITTESTS
69  sigmatch_table[DETECT_ICODE].RegisterTests = DetectICodeRegisterTests;
70 #endif
71  sigmatch_table[DETECT_ICODE].SupportsPrefilter = PrefilterICodeIsPrefilterable;
72  sigmatch_table[DETECT_ICODE].SetupPrefilter = PrefilterSetupICode;
73 }
74 
75 /**
76  * \brief This function is used to match icode rule option set on a packet with those passed via
77  * icode:
78  *
79  * \param t pointer to thread vars
80  * \param det_ctx pointer to the pattern matcher thread
81  * \param p pointer to the current packet
82  * \param ctx pointer to the sigmatch that we will cast into DetectU8Data
83  *
84  * \retval 0 no match
85  * \retval 1 match
86  */
87 static int DetectICodeMatch (DetectEngineThreadCtx *det_ctx, Packet *p,
88  const Signature *s, const SigMatchCtx *ctx)
89 {
91 
92  uint8_t picode;
93  if (PacketIsICMPv4(p)) {
94  picode = p->icmp_s.code;
95  } else if (PacketIsICMPv6(p)) {
96  const ICMPV6Hdr *icmpv6h = PacketGetICMPv6(p);
97  picode = ICMPV6_GET_CODE(icmpv6h);
98  } else {
99  /* Packet not ICMPv4 nor ICMPv6 */
100  return 0;
101  }
102 
103  const DetectU8Data *icd = (const DetectU8Data *)ctx;
104  return DetectU8Match(picode, icd);
105 }
106 
107 /**
108  * \brief this function is used to add the parsed icode data into the current signature
109  *
110  * \param de_ctx pointer to the Detection Engine Context
111  * \param s pointer to the Current Signature
112  * \param icodestr pointer to the user provided icode options
113  *
114  * \retval 0 on Success
115  * \retval -1 on Failure
116  */
117 static int DetectICodeSetup(DetectEngineCtx *de_ctx, Signature *s, const char *icodestr)
118 {
119 
120  DetectU8Data *icd = NULL;
121 
122  icd = DetectU8Parse(icodestr);
123  if (icd == NULL)
124  return -1;
125 
127  NULL) {
128  rs_detect_u8_free(icd);
129  return -1;
130  }
132 
133  return 0;
134 }
135 
136 /**
137  * \brief this function will free memory associated with DetectU8Data
138  *
139  * \param ptr pointer to DetectU8Data
140  */
142 {
143  rs_detect_u8_free(ptr);
144 }
145 
146 /* prefilter code */
147 
148 static void PrefilterPacketICodeMatch(DetectEngineThreadCtx *det_ctx,
149  Packet *p, const void *pectx)
150 {
152 
153  uint8_t picode;
154  if (PacketIsICMPv4(p)) {
155  picode = p->icmp_s.code;
156  } else if (PacketIsICMPv6(p)) {
157  const ICMPV6Hdr *icmpv6h = PacketGetICMPv6(p);
158  picode = ICMPV6_GET_CODE(icmpv6h);
159  } else {
160  /* Packet not ICMPv4 nor ICMPv6 */
161  return;
162  }
163 
164  const PrefilterPacketU8HashCtx *h = pectx;
165  const SigsArray *sa = h->array[picode];
166  if (sa) {
167  PrefilterAddSids(&det_ctx->pmq, sa->sigs, sa->cnt);
168  }
169 }
170 
171 static int PrefilterSetupICode(DetectEngineCtx *de_ctx, SigGroupHead *sgh)
172 {
174  PrefilterPacketU8Set, PrefilterPacketU8Compare, PrefilterPacketICodeMatch);
175 }
176 
177 static bool PrefilterICodeIsPrefilterable(const Signature *s)
178 {
179  const SigMatch *sm;
180  for (sm = s->init_data->smlists[DETECT_SM_LIST_MATCH] ; sm != NULL; sm = sm->next) {
181  switch (sm->type) {
182  case DETECT_ICODE:
183  return true;
184  }
185  }
186  return false;
187 }
188 
189 #ifdef UNITTESTS
190 #include "detect-engine.h"
191 #include "detect-engine-mpm.h"
192 #include "detect-engine-alert.h"
193 
194 /**
195  * \test DetectICodeParseTest01 is a test for setting a valid icode value
196  */
197 static int DetectICodeParseTest01(void)
198 {
199  DetectU8Data *icd = DetectU8Parse("8");
200  FAIL_IF_NULL(icd);
201  FAIL_IF_NOT(icd->arg1 == 8);
202  FAIL_IF_NOT(icd->mode == DETECT_UINT_EQ);
203  DetectICodeFree(NULL, icd);
204 
205  PASS;
206 }
207 
208 /**
209  * \test DetectICodeParseTest02 is a test for setting a valid icode value
210  * with ">" operator
211  */
212 static int DetectICodeParseTest02(void)
213 {
214  DetectU8Data *icd = DetectU8Parse(">8");
215  FAIL_IF_NULL(icd);
216  FAIL_IF_NOT(icd->arg1 == 8);
217  FAIL_IF_NOT(icd->mode == DETECT_UINT_GT);
218  DetectICodeFree(NULL, icd);
219 
220  PASS;
221 }
222 
223 /**
224  * \test DetectICodeParseTest03 is a test for setting a valid icode value
225  * with "<" operator
226  */
227 static int DetectICodeParseTest03(void)
228 {
229  DetectU8Data *icd = DetectU8Parse("<8");
230  FAIL_IF_NULL(icd);
231  FAIL_IF_NOT(icd->arg1 == 8);
232  FAIL_IF_NOT(icd->mode == DETECT_UINT_LT);
233  DetectICodeFree(NULL, icd);
234 
235  PASS;
236 }
237 
238 /**
239  * \test DetectICodeParseTest04 is a test for setting a valid icode value
240  * with "<>" operator
241  */
242 static int DetectICodeParseTest04(void)
243 {
244  DetectU8Data *icd = DetectU8Parse("8<>20");
245  FAIL_IF_NULL(icd);
246  FAIL_IF_NOT(icd->arg1 == 8);
247  FAIL_IF_NOT(icd->arg2 == 20);
248  FAIL_IF_NOT(icd->mode == DETECT_UINT_RA);
249  DetectICodeFree(NULL, icd);
250 
251  PASS;
252 }
253 
254 /**
255  * \test DetectICodeParseTest05 is a test for setting a valid icode value
256  * with spaces all around
257  */
258 static int DetectICodeParseTest05(void)
259 {
260  DetectU8Data *icd = DetectU8Parse(" 8 ");
261  FAIL_IF_NULL(icd);
262  FAIL_IF_NOT(icd->arg1 == 8);
263  FAIL_IF_NOT(icd->mode == DETECT_UINT_EQ);
264  DetectICodeFree(NULL, icd);
265 
266  PASS;
267 }
268 
269 /**
270  * \test DetectICodeParseTest06 is a test for setting a valid icode value
271  * with ">" operator and spaces all around
272  */
273 static int DetectICodeParseTest06(void)
274 {
275  DetectU8Data *icd = DetectU8Parse(" > 8 ");
276  FAIL_IF_NULL(icd);
277  FAIL_IF_NOT(icd->arg1 == 8);
278  FAIL_IF_NOT(icd->mode == DETECT_UINT_GT);
279  DetectICodeFree(NULL, icd);
280 
281  PASS;
282 }
283 
284 /**
285  * \test DetectICodeParseTest07 is a test for setting a valid icode value
286  * with "<>" operator and spaces all around
287  */
288 static int DetectICodeParseTest07(void)
289 {
290  DetectU8Data *icd = DetectU8Parse(" 8 <> 20 ");
291  FAIL_IF_NULL(icd);
292  FAIL_IF_NOT(icd->arg1 == 8);
293  FAIL_IF_NOT(icd->arg2 == 20);
294  FAIL_IF_NOT(icd->mode == DETECT_UINT_RA);
295  DetectICodeFree(NULL, icd);
296 
297  PASS;
298 }
299 
300 /**
301  * \test DetectICodeParseTest08 is a test for setting an invalid icode value
302  */
303 static int DetectICodeParseTest08(void)
304 {
305  DetectU8Data *icd = DetectU8Parse("> 8 <> 20");
306  FAIL_IF_NOT_NULL(icd);
307 
308  PASS;
309 }
310 
311 /**
312  * \test DetectICodeParseTest09 is a test for setting an invalid icode value
313  * with "<<" operator
314  */
315 static int DetectICodeParseTest09(void)
316 {
317  DetectU8Data *icd = DetectU8Parse("8<<20");
318  FAIL_IF_NOT_NULL(icd);
319 
320  PASS;
321 }
322 
323 /**
324  * \test DetectICodeMatchTest01 is a test for checking the working of icode
325  * keyword by creating 5 rules and matching a crafted packet against
326  * them. 4 out of 5 rules shall trigger.
327  */
328 static int DetectICodeMatchTest01(void)
329 {
330  Signature *s = NULL;
331  ThreadVars th_v;
332  DetectEngineThreadCtx *det_ctx;
333 
334  memset(&th_v, 0, sizeof(th_v));
335 
336  Packet *p = UTHBuildPacket(NULL, 0, IPPROTO_ICMP);
337  FAIL_IF_NULL(p);
338  FAIL_IF_NOT(PacketIsICMPv4(p));
339  p->icmp_s.code = p->l4.hdrs.icmpv4h->code = 10;
340 
343 
344  de_ctx->flags |= DE_QUIET;
345 
346  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:10; sid:1;)");
347  FAIL_IF_NULL(s);
348 
349  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:<15; sid:2;)");
350  FAIL_IF_NULL(s);
351 
352  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:>20; sid:3;)");
353  FAIL_IF_NULL(s);
354 
355  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:8<>20; sid:4;)");
356  FAIL_IF_NULL(s);
357 
358  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:20<>8; sid:5;)");
359  FAIL_IF_NOT_NULL(s);
360 
362  DetectEngineThreadCtxInit(&th_v, (void *)de_ctx, (void *)&det_ctx);
363 
364  SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
365 
366  FAIL_IF(PacketAlertCheck(p, 1) == 0);
367  FAIL_IF(PacketAlertCheck(p, 2) == 0);
368  FAIL_IF(PacketAlertCheck(p, 3));
369  FAIL_IF(PacketAlertCheck(p, 4) == 0);
370 
371  DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx);
373 
374  UTHFreePackets(&p, 1);
375 
376  PASS;
377 }
378 
379 /**
380  * \brief this function registers unit tests for DetectICode
381  */
382 void DetectICodeRegisterTests(void)
383 {
384  UtRegisterTest("DetectICodeParseTest01", DetectICodeParseTest01);
385  UtRegisterTest("DetectICodeParseTest02", DetectICodeParseTest02);
386  UtRegisterTest("DetectICodeParseTest03", DetectICodeParseTest03);
387  UtRegisterTest("DetectICodeParseTest04", DetectICodeParseTest04);
388  UtRegisterTest("DetectICodeParseTest05", DetectICodeParseTest05);
389  UtRegisterTest("DetectICodeParseTest06", DetectICodeParseTest06);
390  UtRegisterTest("DetectICodeParseTest07", DetectICodeParseTest07);
391  UtRegisterTest("DetectICodeParseTest08", DetectICodeParseTest08);
392  UtRegisterTest("DetectICodeParseTest09", DetectICodeParseTest09);
393  UtRegisterTest("DetectICodeMatchTest01", DetectICodeMatchTest01);
394 }
395 #endif /* UNITTESTS */
util-byte.h
detect-engine-uint.h
SigTableElmt_::url
const char * url
Definition: detect.h:1304
detect-engine.h
FAIL_IF_NULL
#define FAIL_IF_NULL(expr)
Fail a test if expression evaluates to NULL.
Definition: util-unittest.h:89
SIG_MASK_REQUIRE_REAL_PKT
#define SIG_MASK_REQUIRE_REAL_PKT
Definition: detect.h:306
SignatureInitData_::smlists
struct SigMatch_ * smlists[DETECT_SM_LIST_MAX]
Definition: detect.h:586
SigTableElmt_::desc
const char * desc
Definition: detect.h:1303
sigmatch_table
SigTableElmt * sigmatch_table
Definition: detect-parse.c:127
SigTableElmt_::Free
void(* Free)(DetectEngineCtx *, void *)
Definition: detect.h:1291
SigTableElmt_::name
const char * name
Definition: detect.h:1301
PKT_IS_PSEUDOPKT
#define PKT_IS_PSEUDOPKT(p)
return 1 if the packet is a pseudo packet
Definition: decode.h:1326
SigGroupHead_
Container for matching data for a signature group.
Definition: detect.h:1457
UtRegisterTest
void UtRegisterTest(const char *name, int(*TestFn)(void))
Register unit test.
Definition: util-unittest.c:103
DETECT_UINT_LT
#define DETECT_UINT_LT
Definition: detect-engine-uint.h:37
PrefilterPacketU8HashCtx_::array
SigsArray * array[256]
Definition: detect-engine-prefilter-common.h:53
PacketAlertCheck
int PacketAlertCheck(Packet *p, uint32_t sid)
Check if a certain sid alerted, this is used in the test functions.
Definition: detect-engine-alert.c:141
DetectEngineThreadCtx_::pmq
PrefilterRuleStore pmq
Definition: detect.h:1197
ctx
struct Thresholds ctx
DetectEngineCtx_
main detection engine ctx
Definition: detect.h:841
DetectEngineCtxFree
void DetectEngineCtxFree(DetectEngineCtx *)
Free a DetectEngineCtx::
Definition: detect-engine.c:2597
DETECT_UINT_EQ
#define DETECT_UINT_EQ
Definition: detect-engine-uint.h:35
DE_QUIET
#define DE_QUIET
Definition: detect.h:323
UTHBuildPacket
Packet * UTHBuildPacket(uint8_t *payload, uint16_t payload_len, uint8_t ipproto)
UTHBuildPacket is a wrapper that build packets with default ip and port fields.
Definition: util-unittest-helper.c:359
SigMatchSignatures
void SigMatchSignatures(ThreadVars *tv, DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, Packet *p)
wrapper for old tests
Definition: detect.c:1926
Packet_::icmp_s
struct Packet_::@29::@36 icmp_s
DETECT_UINT_GT
#define DETECT_UINT_GT
Definition: detect-engine-uint.h:32
DetectEngineAppendSig
Signature * DetectEngineAppendSig(DetectEngineCtx *, const char *)
Parse and append a Signature into the Detection Engine Context signature list.
Definition: detect-parse.c:2587
SigTableElmt_::Setup
int(* Setup)(DetectEngineCtx *, Signature *, const char *)
Definition: detect.h:1286
util-unittest.h
util-unittest-helper.h
FAIL_IF_NOT
#define FAIL_IF_NOT(expr)
Fail a test if expression evaluates to false.
Definition: util-unittest.h:82
SigTableElmt_::SetupPrefilter
int(* SetupPrefilter)(DetectEngineCtx *de_ctx, struct SigGroupHead_ *sgh)
Definition: detect.h:1289
DetectU8Parse
DetectUintData_u8 * DetectU8Parse(const char *u8str)
This function is used to parse u8 options passed via some u8 keyword.
Definition: detect-engine-uint.c:85
decode.h
FAIL_IF_NOT_NULL
#define FAIL_IF_NOT_NULL(expr)
Fail a test if expression evaluates to non-NULL.
Definition: util-unittest.h:96
util-debug.h
PrefilterSetupPacketHeaderU8Hash
int PrefilterSetupPacketHeaderU8Hash(DetectEngineCtx *de_ctx, SigGroupHead *sgh, int sm_type, SignatureMask mask, void(*Set)(PrefilterPacketHeaderValue *v, void *), bool(*Compare)(PrefilterPacketHeaderValue v, void *), void(*Match)(DetectEngineThreadCtx *det_ctx, Packet *p, const void *pectx))
Definition: detect-engine-prefilter-common.c:396
PASS
#define PASS
Pass the test.
Definition: util-unittest.h:105
de_ctx
DetectEngineCtx * de_ctx
Definition: fuzz_siginit.c:17
DetectICodeRegister
void DetectICodeRegister(void)
Registration function for icode: keyword.
Definition: detect-icode.c:60
DetectEngineThreadCtx_
Definition: detect.h:1090
DETECT_ICODE
@ DETECT_ICODE
Definition: detect-engine-register.h:48
detect-engine-mpm.h
detect.h
ThreadVars_
Per thread variable structure.
Definition: threadvars.h:57
SigMatch_::next
struct SigMatch_ * next
Definition: detect.h:353
DetectU8Data
DetectUintData_u8 DetectU8Data
Definition: detect-engine-uint.h:43
DETECT_SM_LIST_MATCH
@ DETECT_SM_LIST_MATCH
Definition: detect.h:114
PrefilterPacketU8Set
void PrefilterPacketU8Set(PrefilterPacketHeaderValue *v, void *smctx)
Definition: detect-engine-uint.c:90
PacketL4::L4Hdrs::icmpv4h
ICMPV4Hdr * icmpv4h
Definition: decode.h:449
Signature_::flags
uint32_t flags
Definition: detect.h:602
Packet_
Definition: decode.h:479
detect-engine-build.h
detect-engine-alert.h
Packet_::l4
struct PacketL4 l4
Definition: decode.h:576
ICMPV6_GET_CODE
#define ICMPV6_GET_CODE(icmp6h)
Definition: decode-icmpv6.h:103
Signature_::init_data
SignatureInitData * init_data
Definition: detect.h:670
SigTableElmt_::Match
int(* Match)(DetectEngineThreadCtx *, Packet *, const Signature *, const SigMatchCtx *)
Definition: detect.h:1269
SigGroupBuild
int SigGroupBuild(DetectEngineCtx *de_ctx)
Convert the signature list into the runtime match structure.
Definition: detect-engine-build.c:2161
SigMatchCtx_
Used to start a pointer to SigMatch context Should never be dereferenced without casting to something...
Definition: detect.h:344
ICMPV6Hdr_
Definition: decode-icmpv6.h:129
DetectU8Match
int DetectU8Match(const uint8_t parg, const DetectUintData_u8 *du8)
Definition: detect-engine-uint.c:71
DetectEngineThreadCtxInit
TmEcode DetectEngineThreadCtxInit(ThreadVars *, void *, void **)
initialize thread specific detection engine context
Definition: detect-engine.c:3312
FAIL_IF
#define FAIL_IF(expr)
Fail a test if expression evaluates to true.
Definition: util-unittest.h:71
SigsArray_::sigs
SigIntId * sigs
Definition: detect-engine-prefilter-common.h:47
DetectICodeFree
void DetectICodeFree(DetectEngineCtx *, void *)
this function will free memory associated with DetectU8Data
Definition: detect-icode.c:141
suricata-common.h
DetectEngineThreadCtxDeinit
TmEcode DetectEngineThreadCtxDeinit(ThreadVars *, void *)
Definition: detect-engine.c:3539
SigMatch_::type
uint16_t type
Definition: detect.h:350
SigsArray_
Definition: detect-engine-prefilter-common.h:46
SigsArray_::cnt
uint32_t cnt
Definition: detect-engine-prefilter-common.h:48
ICMPV4Hdr_::code
uint8_t code
Definition: decode-icmpv4.h:167
SigTableElmt_::SupportsPrefilter
bool(* SupportsPrefilter)(const Signature *s)
Definition: detect.h:1288
detect-parse.h
detect-icode.h
Signature_
Signature container.
Definition: detect.h:601
SigMatch_
a single match condition for a signature
Definition: detect.h:349
PacketL4::hdrs
union PacketL4::L4Hdrs hdrs
DetectEngineCtxInit
DetectEngineCtx * DetectEngineCtxInit(void)
Definition: detect-engine.c:2558
PrefilterPacketU8Compare
bool PrefilterPacketU8Compare(PrefilterPacketHeaderValue v, void *smctx)
Definition: detect-engine-uint.c:98
PrefilterPacketU8HashCtx_
Definition: detect-engine-prefilter-common.h:52
SigMatchAppendSMToList
SigMatch * SigMatchAppendSMToList(DetectEngineCtx *de_ctx, Signature *s, uint16_t type, SigMatchCtx *ctx, const int list)
Append a SigMatch to the list type.
Definition: detect-parse.c:436
DetectEngineCtx_::flags
uint8_t flags
Definition: detect.h:843
detect-engine-prefilter-common.h
DEBUG_VALIDATE_BUG_ON
#define DEBUG_VALIDATE_BUG_ON(exp)
Definition: util-validate.h:102
DETECT_UINT_RA
#define DETECT_UINT_RA
Definition: detect-engine-uint.h:34
SigTableElmt_::RegisterTests
void(* RegisterTests)(void)
Definition: detect.h:1293
SIG_FLAG_REQUIRE_PACKET
#define SIG_FLAG_REQUIRE_PACKET
Definition: detect.h:250
UTHFreePackets
void UTHFreePackets(Packet **p, int numpkts)
UTHFreePackets: function to release the allocated data from UTHBuildPacket and the packet itself.
Definition: util-unittest-helper.c:450