suricata
detect-icode.c
Go to the documentation of this file.
1 /* Copyright (C) 2007-2021 Open Information Security Foundation
2  *
3  * You can copy, redistribute or modify this Program under the terms of
4  * the GNU General Public License version 2 as published by the Free
5  * Software Foundation.
6  *
7  * This program is distributed in the hope that it will be useful,
8  * but WITHOUT ANY WARRANTY; without even the implied warranty of
9  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10  * GNU General Public License for more details.
11  *
12  * You should have received a copy of the GNU General Public License
13  * version 2 along with this program; if not, write to the Free Software
14  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
15  * 02110-1301, USA.
16  */
17 
18 /**
19  * \file
20  *
21  * \author Gerardo Iglesias <iglesiasg@gmail.com>
22  *
23  * Implements icode keyword support
24  */
25 
26 #include "suricata-common.h"
27 #include "decode.h"
28 
29 #include "detect.h"
30 #include "detect-parse.h"
32 #include "detect-engine-uint.h"
33 #include "detect-engine-build.h"
34 
35 #include "detect-icode.h"
36 
37 #include "util-byte.h"
38 #include "util-unittest.h"
39 #include "util-unittest-helper.h"
40 #include "util-debug.h"
41 
42 /**
43  *\brief Regex for parsing our icode options
44  */
45 
46 static int DetectICodeMatch(DetectEngineThreadCtx *, Packet *,
47  const Signature *, const SigMatchCtx *);
48 static int DetectICodeSetup(DetectEngineCtx *, Signature *, const char *);
49 #ifdef UNITTESTS
50 static void DetectICodeRegisterTests(void);
51 #endif
52 void DetectICodeFree(DetectEngineCtx *, void *);
53 
54 static int PrefilterSetupICode(DetectEngineCtx *de_ctx, SigGroupHead *sgh);
55 static bool PrefilterICodeIsPrefilterable(const Signature *s);
56 
57 /**
58  * \brief Registration function for icode: keyword
59  */
61 {
62  sigmatch_table[DETECT_ICODE].name = "icode";
63  sigmatch_table[DETECT_ICODE].desc = "match on specific ICMP id-value";
64  sigmatch_table[DETECT_ICODE].url = "/rules/header-keywords.html#icode";
65  sigmatch_table[DETECT_ICODE].Match = DetectICodeMatch;
66  sigmatch_table[DETECT_ICODE].Setup = DetectICodeSetup;
68 #ifdef UNITTESTS
69  sigmatch_table[DETECT_ICODE].RegisterTests = DetectICodeRegisterTests;
70 #endif
71  sigmatch_table[DETECT_ICODE].SupportsPrefilter = PrefilterICodeIsPrefilterable;
72  sigmatch_table[DETECT_ICODE].SetupPrefilter = PrefilterSetupICode;
73 }
74 
75 /**
76  * \brief This function is used to match icode rule option set on a packet with those passed via
77  * icode:
78  *
79  * \param t pointer to thread vars
80  * \param det_ctx pointer to the pattern matcher thread
81  * \param p pointer to the current packet
82  * \param ctx pointer to the sigmatch that we will cast into DetectU8Data
83  *
84  * \retval 0 no match
85  * \retval 1 match
86  */
87 static int DetectICodeMatch (DetectEngineThreadCtx *det_ctx, Packet *p,
88  const Signature *s, const SigMatchCtx *ctx)
89 {
90  if (PKT_IS_PSEUDOPKT(p))
91  return 0;
92 
93  uint8_t picode;
94  if (PKT_IS_ICMPV4(p)) {
95  picode = ICMPV4_GET_CODE(p);
96  } else if (PKT_IS_ICMPV6(p)) {
97  picode = ICMPV6_GET_CODE(p);
98  } else {
99  /* Packet not ICMPv4 nor ICMPv6 */
100  return 0;
101  }
102 
103  const DetectU8Data *icd = (const DetectU8Data *)ctx;
104  return DetectU8Match(picode, icd);
105 }
106 
107 /**
108  * \brief this function is used to add the parsed icode data into the current signature
109  *
110  * \param de_ctx pointer to the Detection Engine Context
111  * \param s pointer to the Current Signature
112  * \param icodestr pointer to the user provided icode options
113  *
114  * \retval 0 on Success
115  * \retval -1 on Failure
116  */
117 static int DetectICodeSetup(DetectEngineCtx *de_ctx, Signature *s, const char *icodestr)
118 {
119 
120  DetectU8Data *icd = NULL;
121 
122  icd = DetectU8Parse(icodestr);
123  if (icd == NULL) goto error;
124 
126  NULL) {
127  goto error;
128  }
130 
131  return 0;
132 
133 error:
134  if (icd != NULL)
135  rs_detect_u8_free(icd);
136  return -1;
137 }
138 
139 /**
140  * \brief this function will free memory associated with DetectU8Data
141  *
142  * \param ptr pointer to DetectU8Data
143  */
145 {
146  rs_detect_u8_free(ptr);
147 }
148 
149 /* prefilter code */
150 
151 static void PrefilterPacketICodeMatch(DetectEngineThreadCtx *det_ctx,
152  Packet *p, const void *pectx)
153 {
154  if (PKT_IS_PSEUDOPKT(p)) {
155  SCReturn;
156  }
157 
158  uint8_t picode;
159  if (PKT_IS_ICMPV4(p)) {
160  picode = ICMPV4_GET_CODE(p);
161  } else if (PKT_IS_ICMPV6(p)) {
162  picode = ICMPV6_GET_CODE(p);
163  } else {
164  /* Packet not ICMPv4 nor ICMPv6 */
165  return;
166  }
167 
168  const PrefilterPacketU8HashCtx *h = pectx;
169  const SigsArray *sa = h->array[picode];
170  if (sa) {
171  PrefilterAddSids(&det_ctx->pmq, sa->sigs, sa->cnt);
172  }
173 }
174 
175 static int PrefilterSetupICode(DetectEngineCtx *de_ctx, SigGroupHead *sgh)
176 {
178  PrefilterPacketU8Compare, PrefilterPacketICodeMatch);
179 }
180 
181 static bool PrefilterICodeIsPrefilterable(const Signature *s)
182 {
183  const SigMatch *sm;
184  for (sm = s->init_data->smlists[DETECT_SM_LIST_MATCH] ; sm != NULL; sm = sm->next) {
185  switch (sm->type) {
186  case DETECT_ICODE:
187  return true;
188  }
189  }
190  return false;
191 }
192 
193 #ifdef UNITTESTS
194 #include "detect-engine.h"
195 #include "detect-engine-mpm.h"
196 #include "detect-engine-alert.h"
197 
198 /**
199  * \test DetectICodeParseTest01 is a test for setting a valid icode value
200  */
201 static int DetectICodeParseTest01(void)
202 {
203  DetectU8Data *icd = DetectU8Parse("8");
204  FAIL_IF_NULL(icd);
205  FAIL_IF_NOT(icd->arg1 == 8);
206  FAIL_IF_NOT(icd->mode == DETECT_UINT_EQ);
207  DetectICodeFree(NULL, icd);
208 
209  PASS;
210 }
211 
212 /**
213  * \test DetectICodeParseTest02 is a test for setting a valid icode value
214  * with ">" operator
215  */
216 static int DetectICodeParseTest02(void)
217 {
218  DetectU8Data *icd = DetectU8Parse(">8");
219  FAIL_IF_NULL(icd);
220  FAIL_IF_NOT(icd->arg1 == 8);
221  FAIL_IF_NOT(icd->mode == DETECT_UINT_GT);
222  DetectICodeFree(NULL, icd);
223 
224  PASS;
225 }
226 
227 /**
228  * \test DetectICodeParseTest03 is a test for setting a valid icode value
229  * with "<" operator
230  */
231 static int DetectICodeParseTest03(void)
232 {
233  DetectU8Data *icd = DetectU8Parse("<8");
234  FAIL_IF_NULL(icd);
235  FAIL_IF_NOT(icd->arg1 == 8);
236  FAIL_IF_NOT(icd->mode == DETECT_UINT_LT);
237  DetectICodeFree(NULL, icd);
238 
239  PASS;
240 }
241 
242 /**
243  * \test DetectICodeParseTest04 is a test for setting a valid icode value
244  * with "<>" operator
245  */
246 static int DetectICodeParseTest04(void)
247 {
248  DetectU8Data *icd = DetectU8Parse("8<>20");
249  FAIL_IF_NULL(icd);
250  FAIL_IF_NOT(icd->arg1 == 8);
251  FAIL_IF_NOT(icd->arg2 == 20);
252  FAIL_IF_NOT(icd->mode == DETECT_UINT_RA);
253  DetectICodeFree(NULL, icd);
254 
255  PASS;
256 }
257 
258 /**
259  * \test DetectICodeParseTest05 is a test for setting a valid icode value
260  * with spaces all around
261  */
262 static int DetectICodeParseTest05(void)
263 {
264  DetectU8Data *icd = DetectU8Parse(" 8 ");
265  FAIL_IF_NULL(icd);
266  FAIL_IF_NOT(icd->arg1 == 8);
267  FAIL_IF_NOT(icd->mode == DETECT_UINT_EQ);
268  DetectICodeFree(NULL, icd);
269 
270  PASS;
271 }
272 
273 /**
274  * \test DetectICodeParseTest06 is a test for setting a valid icode value
275  * with ">" operator and spaces all around
276  */
277 static int DetectICodeParseTest06(void)
278 {
279  DetectU8Data *icd = DetectU8Parse(" > 8 ");
280  FAIL_IF_NULL(icd);
281  FAIL_IF_NOT(icd->arg1 == 8);
282  FAIL_IF_NOT(icd->mode == DETECT_UINT_GT);
283  DetectICodeFree(NULL, icd);
284 
285  PASS;
286 }
287 
288 /**
289  * \test DetectICodeParseTest07 is a test for setting a valid icode value
290  * with "<>" operator and spaces all around
291  */
292 static int DetectICodeParseTest07(void)
293 {
294  DetectU8Data *icd = DetectU8Parse(" 8 <> 20 ");
295  FAIL_IF_NULL(icd);
296  FAIL_IF_NOT(icd->arg1 == 8);
297  FAIL_IF_NOT(icd->arg2 == 20);
298  FAIL_IF_NOT(icd->mode == DETECT_UINT_RA);
299  DetectICodeFree(NULL, icd);
300 
301  PASS;
302 }
303 
304 /**
305  * \test DetectICodeParseTest08 is a test for setting an invalid icode value
306  */
307 static int DetectICodeParseTest08(void)
308 {
309  DetectU8Data *icd = DetectU8Parse("> 8 <> 20");
310  FAIL_IF_NOT_NULL(icd);
311 
312  DetectICodeFree(NULL, icd);
313  PASS;
314 }
315 
316 /**
317  * \test DetectICodeParseTest09 is a test for setting an invalid icode value
318  * with "<<" operator
319  */
320 static int DetectICodeParseTest09(void)
321 {
322  DetectU8Data *icd = DetectU8Parse("8<<20");
323  FAIL_IF_NOT_NULL(icd);
324 
325  DetectICodeFree(NULL, icd);
326  PASS;
327 }
328 
329 /**
330  * \test DetectICodeMatchTest01 is a test for checking the working of icode
331  * keyword by creating 5 rules and matching a crafted packet against
332  * them. 4 out of 5 rules shall trigger.
333  */
334 static int DetectICodeMatchTest01(void)
335 {
336 
337  Packet *p = NULL;
338  Signature *s = NULL;
339  ThreadVars th_v;
340  DetectEngineThreadCtx *det_ctx;
341 
342  memset(&th_v, 0, sizeof(th_v));
343 
344  p = UTHBuildPacket(NULL, 0, IPPROTO_ICMP);
345 
346  p->icmpv4h->code = 10;
347 
350 
351  de_ctx->flags |= DE_QUIET;
352 
353  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:10; sid:1;)");
354  FAIL_IF_NULL(s);
355 
356  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:<15; sid:2;)");
357  FAIL_IF_NULL(s);
358 
359  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:>20; sid:3;)");
360  FAIL_IF_NULL(s);
361 
362  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:8<>20; sid:4;)");
363  FAIL_IF_NULL(s);
364 
365  s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any (icode:20<>8; sid:5;)");
366  FAIL_IF_NOT_NULL(s);
367 
369  DetectEngineThreadCtxInit(&th_v, (void *)de_ctx, (void *)&det_ctx);
370 
371  SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
372 
373  FAIL_IF(PacketAlertCheck(p, 1) == 0);
374  FAIL_IF(PacketAlertCheck(p, 2) == 0);
375  FAIL_IF(PacketAlertCheck(p, 3));
376  FAIL_IF(PacketAlertCheck(p, 4) == 0);
377 
378  DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx);
380 
381  UTHFreePackets(&p, 1);
382 
383  PASS;
384 }
385 
386 /**
387  * \brief this function registers unit tests for DetectICode
388  */
389 void DetectICodeRegisterTests(void)
390 {
391  UtRegisterTest("DetectICodeParseTest01", DetectICodeParseTest01);
392  UtRegisterTest("DetectICodeParseTest02", DetectICodeParseTest02);
393  UtRegisterTest("DetectICodeParseTest03", DetectICodeParseTest03);
394  UtRegisterTest("DetectICodeParseTest04", DetectICodeParseTest04);
395  UtRegisterTest("DetectICodeParseTest05", DetectICodeParseTest05);
396  UtRegisterTest("DetectICodeParseTest06", DetectICodeParseTest06);
397  UtRegisterTest("DetectICodeParseTest07", DetectICodeParseTest07);
398  UtRegisterTest("DetectICodeParseTest08", DetectICodeParseTest08);
399  UtRegisterTest("DetectICodeParseTest09", DetectICodeParseTest09);
400  UtRegisterTest("DetectICodeMatchTest01", DetectICodeMatchTest01);
401 }
402 #endif /* UNITTESTS */
util-byte.h
detect-engine-uint.h
SigTableElmt_::url
const char * url
Definition: detect.h:1296
detect-engine.h
FAIL_IF_NULL
#define FAIL_IF_NULL(expr)
Fail a test if expression evaluates to NULL.
Definition: util-unittest.h:89
ICMPV4_GET_CODE
#define ICMPV4_GET_CODE(p)
Definition: decode-icmpv4.h:235
SignatureInitData_::smlists
struct SigMatch_ * smlists[DETECT_SM_LIST_MAX]
Definition: detect.h:578
SigTableElmt_::desc
const char * desc
Definition: detect.h:1295
SigTableElmt_::Free
void(* Free)(DetectEngineCtx *, void *)
Definition: detect.h:1283
SigTableElmt_::name
const char * name
Definition: detect.h:1293
PKT_IS_PSEUDOPKT
#define PKT_IS_PSEUDOPKT(p)
return 1 if the packet is a pseudo packet
Definition: decode.h:1075
SigGroupHead_
Container for matching data for a signature group.
Definition: detect.h:1445
UtRegisterTest
void UtRegisterTest(const char *name, int(*TestFn)(void))
Register unit test.
Definition: util-unittest.c:103
DETECT_UINT_LT
#define DETECT_UINT_LT
Definition: detect-engine-uint.h:37
PrefilterPacketU8HashCtx_::array
SigsArray * array[256]
Definition: detect-engine-prefilter-common.h:53
PacketAlertCheck
int PacketAlertCheck(Packet *p, uint32_t sid)
Check if a certain sid alerted, this is used in the test functions.
Definition: detect-engine-alert.c:141
DetectEngineThreadCtx_::pmq
PrefilterRuleStore pmq
Definition: detect.h:1201
DetectEngineCtx_
main detection engine ctx
Definition: detect.h:836
DetectEngineCtxFree
void DetectEngineCtxFree(DetectEngineCtx *)
Free a DetectEngineCtx::
Definition: detect-engine.c:2533
DETECT_UINT_EQ
#define DETECT_UINT_EQ
Definition: detect-engine-uint.h:35
ICMPV6_GET_CODE
#define ICMPV6_GET_CODE(p)
Definition: decode-icmpv6.h:103
DE_QUIET
#define DE_QUIET
Definition: detect.h:321
UTHBuildPacket
Packet * UTHBuildPacket(uint8_t *payload, uint16_t payload_len, uint8_t ipproto)
UTHBuildPacket is a wrapper that build packets with default ip and port fields.
Definition: util-unittest-helper.c:340
SigMatchSignatures
void SigMatchSignatures(ThreadVars *tv, DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, Packet *p)
wrapper for old tests
Definition: detect.c:1884
DETECT_UINT_GT
#define DETECT_UINT_GT
Definition: detect-engine-uint.h:32
DetectEngineAppendSig
Signature * DetectEngineAppendSig(DetectEngineCtx *, const char *)
Parse and append a Signature into the Detection Engine Context signature list.
Definition: detect-parse.c:2620
SigTableElmt_::Setup
int(* Setup)(DetectEngineCtx *, Signature *, const char *)
Definition: detect.h:1278
util-unittest.h
util-unittest-helper.h
FAIL_IF_NOT
#define FAIL_IF_NOT(expr)
Fail a test if expression evaluates to false.
Definition: util-unittest.h:82
SigTableElmt_::SetupPrefilter
int(* SetupPrefilter)(DetectEngineCtx *de_ctx, struct SigGroupHead_ *sgh)
Definition: detect.h:1281
DetectU8Parse
DetectUintData_u8 * DetectU8Parse(const char *u8str)
This function is used to parse u8 options passed via some u8 keyword.
Definition: detect-engine-uint.c:85
decode.h
FAIL_IF_NOT_NULL
#define FAIL_IF_NOT_NULL(expr)
Fail a test if expression evaluates to non-NULL.
Definition: util-unittest.h:96
util-debug.h
PASS
#define PASS
Pass the test.
Definition: util-unittest.h:105
de_ctx
DetectEngineCtx * de_ctx
Definition: fuzz_siginit.c:17
DetectICodeRegister
void DetectICodeRegister(void)
Registration function for icode: keyword.
Definition: detect-icode.c:60
DetectEngineThreadCtx_
Definition: detect.h:1092
DETECT_ICODE
@ DETECT_ICODE
Definition: detect-engine-register.h:48
detect-engine-mpm.h
detect.h
ThreadVars_
Per thread variable structure.
Definition: threadvars.h:57
SigMatch_::next
struct SigMatch_ * next
Definition: detect.h:351
DetectU8Data
DetectUintData_u8 DetectU8Data
Definition: detect-engine-uint.h:43
DETECT_SM_LIST_MATCH
@ DETECT_SM_LIST_MATCH
Definition: detect.h:111
PrefilterPacketU8Set
void PrefilterPacketU8Set(PrefilterPacketHeaderValue *v, void *smctx)
Definition: detect-engine-uint.c:90
PKT_IS_ICMPV6
#define PKT_IS_ICMPV6(p)
Definition: decode.h:251
SCReturn
#define SCReturn
Definition: util-debug.h:273
Signature_::flags
uint32_t flags
Definition: detect.h:594
Packet_
Definition: decode.h:437
detect-engine-build.h
detect-engine-alert.h
Signature_::init_data
SignatureInitData * init_data
Definition: detect.h:662
SigTableElmt_::Match
int(* Match)(DetectEngineThreadCtx *, Packet *, const Signature *, const SigMatchCtx *)
Definition: detect.h:1261
SigGroupBuild
int SigGroupBuild(DetectEngineCtx *de_ctx)
Convert the signature list into the runtime match structure.
Definition: detect-engine-build.c:2149
SigMatchCtx_
Used to start a pointer to SigMatch context Should never be dereferenced without casting to something...
Definition: detect.h:342
DetectU8Match
int DetectU8Match(const uint8_t parg, const DetectUintData_u8 *du8)
Definition: detect-engine-uint.c:71
DetectEngineThreadCtxInit
TmEcode DetectEngineThreadCtxInit(ThreadVars *, void *, void **)
initialize thread specific detection engine context
Definition: detect-engine.c:3244
FAIL_IF
#define FAIL_IF(expr)
Fail a test if expression evaluates to true.
Definition: util-unittest.h:71
SigsArray_::sigs
SigIntId * sigs
Definition: detect-engine-prefilter-common.h:47
DetectICodeFree
void DetectICodeFree(DetectEngineCtx *, void *)
this function will free memory associated with DetectU8Data
Definition: detect-icode.c:144
suricata-common.h
DetectEngineThreadCtxDeinit
TmEcode DetectEngineThreadCtxDeinit(ThreadVars *, void *)
Definition: detect-engine.c:3454
SigMatch_::type
uint16_t type
Definition: detect.h:348
SigsArray_
Definition: detect-engine-prefilter-common.h:46
sigmatch_table
SigTableElmt sigmatch_table[DETECT_TBLSIZE]
Definition: detect-parse.c:127
SigsArray_::cnt
uint32_t cnt
Definition: detect-engine-prefilter-common.h:48
ICMPV4Hdr_::code
uint8_t code
Definition: decode-icmpv4.h:167
Packet_::icmpv4h
ICMPV4Hdr * icmpv4h
Definition: decode.h:575
PKT_IS_ICMPV4
#define PKT_IS_ICMPV4(p)
Definition: decode.h:250
SigTableElmt_::SupportsPrefilter
bool(* SupportsPrefilter)(const Signature *s)
Definition: detect.h:1280
detect-parse.h
detect-icode.h
Signature_
Signature container.
Definition: detect.h:593
SigMatch_
a single match condition for a signature
Definition: detect.h:347
DetectEngineCtxInit
DetectEngineCtx * DetectEngineCtxInit(void)
Definition: detect-engine.c:2494
PrefilterPacketU8Compare
bool PrefilterPacketU8Compare(PrefilterPacketHeaderValue v, void *smctx)
Definition: detect-engine-uint.c:98
PrefilterPacketU8HashCtx_
Definition: detect-engine-prefilter-common.h:52
SigMatchAppendSMToList
SigMatch * SigMatchAppendSMToList(DetectEngineCtx *de_ctx, Signature *s, uint16_t type, SigMatchCtx *ctx, const int list)
Append a SigMatch to the list type.
Definition: detect-parse.c:447
DetectEngineCtx_::flags
uint8_t flags
Definition: detect.h:838
detect-engine-prefilter-common.h
PrefilterSetupPacketHeaderU8Hash
int PrefilterSetupPacketHeaderU8Hash(DetectEngineCtx *de_ctx, SigGroupHead *sgh, int sm_type, void(*Set)(PrefilterPacketHeaderValue *v, void *), bool(*Compare)(PrefilterPacketHeaderValue v, void *), void(*Match)(DetectEngineThreadCtx *det_ctx, Packet *p, const void *pectx))
Definition: detect-engine-prefilter-common.c:407
DETECT_UINT_RA
#define DETECT_UINT_RA
Definition: detect-engine-uint.h:34
SigTableElmt_::RegisterTests
void(* RegisterTests)(void)
Definition: detect.h:1285
SIG_FLAG_REQUIRE_PACKET
#define SIG_FLAG_REQUIRE_PACKET
Definition: detect.h:246
UTHFreePackets
void UTHFreePackets(Packet **p, int numpkts)
UTHFreePackets: function to release the allocated data from UTHBuildPacket and the packet itself.
Definition: util-unittest-helper.c:431