detect-engine-alert.c

Go to the documentation of this file.

/* Copyright (C) 2007-2026 Open Information Security Foundation
 *
 * You can copy, redistribute or modify this Program under the terms of
 * the GNU General Public License version 2 as published by the Free
 * Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * version 2 along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
 * 02110-1301, USA.
 */
 
#include "suricata-common.h"
#include "suricata.h"
 
#include "detect.h"
#include "detect-parse.h"
#include "detect-engine-alert.h"
#include "detect-engine-threshold.h"
#include "detect-engine-tag.h"
 
#include "decode.h"
#include "packet.h"
 
#include "flow.h"
#include "flow-private.h"
 
#ifdef QA_SIMULATION
#include "util-exception-policy.h"
#endif
 
#include "util-profiling.h"
#include "util-validate.h"
 
#include "action-globals.h"
#include "capture-hooks.h"
 
/** tag signature we use for tag alerts */
static Signature g_tag_signature;
/** tag packet alert structure for tag alerts */
static PacketAlert g_tag_pa;
 
void PacketAlertTagInit(void)
{
    memset(&g_tag_signature, 0x00, sizeof(g_tag_signature));
 
    g_tag_signature.id = TAG_SIG_ID;
    g_tag_signature.gid = TAG_SIG_GEN;
    g_tag_signature.iid = TAG_SIG_ID;
    g_tag_signature.rev = 1;
    g_tag_signature.prio = 2;
 
    memset(&g_tag_pa, 0x00, sizeof(g_tag_pa));
 
    g_tag_pa.action = ACTION_ALERT;
    g_tag_pa.s = &g_tag_signature;
}
 
/**
 * \brief Handle a packet and check if needs a threshold logic
 *        Also apply rule action if necessary.
 *
 * \param de_ctx Detection Context
 * \param sig Signature pointer
 * \param p Packet structure
 *
 * \retval 1 alert is not suppressed
 * \retval 0 alert is suppressed
 */
static int PacketAlertHandle(const DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx,
        const Signature *s, Packet *p, PacketAlert *pa)
{
    SCEnter();
    int ret = 1;
    const DetectThresholdData *td = NULL;
    const SigMatchData *smd;
 
    if (!(PacketIsIPv4(p) || PacketIsIPv6(p))) {
        SCReturnInt(1);
    }
 
    /* handle suppressions first */
    if (s->sm_arrays[DETECT_SM_LIST_SUPPRESS] != NULL) {
        KEYWORD_PROFILING_SET_LIST(det_ctx, DETECT_SM_LIST_SUPPRESS);
        smd = NULL;
        do {
            td = SigGetThresholdTypeIter(s, &smd, DETECT_SM_LIST_SUPPRESS);
            if (td != NULL) {
                SCLogDebug("td %p", td);
 
                /* PacketAlertThreshold returns 2 if the alert is suppressed but
                 * we do need to apply rule actions to the packet. */
                KEYWORD_PROFILING_START;
                ret = PacketAlertThreshold(de_ctx, det_ctx, td, p, s, pa);
                if (ret == 0 || ret == 2) {
                    KEYWORD_PROFILING_END(det_ctx, DETECT_THRESHOLD, 0);
                    /* It doesn't match threshold, remove it */
                    SCReturnInt(ret);
                }
                KEYWORD_PROFILING_END(det_ctx, DETECT_THRESHOLD, 1);
            }
        } while (smd != NULL);
    }
 
    /* if we're still here, consider thresholding */
    if (s->sm_arrays[DETECT_SM_LIST_THRESHOLD] != NULL) {
        KEYWORD_PROFILING_SET_LIST(det_ctx, DETECT_SM_LIST_THRESHOLD);
        smd = NULL;
        do {
            td = SigGetThresholdTypeIter(s, &smd, DETECT_SM_LIST_THRESHOLD);
            if (td != NULL) {
                SCLogDebug("td %p", td);
 
                /* PacketAlertThreshold returns 2 if the alert is suppressed but
                 * we do need to apply rule actions to the packet. */
                KEYWORD_PROFILING_START;
                ret = PacketAlertThreshold(de_ctx, det_ctx, td, p, s, pa);
                if (ret == 0 || ret == 2) {
                    KEYWORD_PROFILING_END(det_ctx, DETECT_THRESHOLD ,0);
                    /* It doesn't match threshold, remove it */
                    SCReturnInt(ret);
                }
                KEYWORD_PROFILING_END(det_ctx, DETECT_THRESHOLD, 1);
            }
        } while (smd != NULL);
    }
    SCReturnInt(1);
}
 
#ifdef UNITTESTS
/**
 * \brief Check if a certain sid alerted, this is used in the test functions
 *
 * \param p   Packet on which we want to check if the signature alerted or not
 * \param sid Signature id of the signature that has to be checked for a match
 *
 * \retval match A value > 0 on a match; 0 on no match
 */
int PacketAlertCheck(Packet *p, uint32_t sid)
{
    int match = 0;
 
    for (uint16_t i = 0; i < p->alerts.cnt; i++) {
        BUG_ON(p->alerts.alerts[i].s == NULL);
        if (p->alerts.alerts[i].s->id == sid)
            match++;
    }
 
    return match;
}
#endif
 
static inline void RuleActionToFlow(const uint8_t action, Flow *f, const bool fw_rule)
{
    if (action & ACTION_ACCEPT) {
        DEBUG_VALIDATE_BUG_ON(!fw_rule);
        f->flags |= (FLOW_ACTION_ACCEPT | FLOW_ACTION_BY_FIREWALL);
        SCLogDebug("setting flow action accept");
    }
 
    /* pass:flow can be set if accept:flow is present */
    if (action & ACTION_PASS) {
        if (f->flags & (FLOW_ACTION_DROP | FLOW_ACTION_PASS)) {
            /* drop or pass already set. First to set wins. */
            SCLogDebug("not setting %s flow already set to %s",
                    (action & ACTION_PASS) ? "pass" : "drop",
                    (f->flags & FLOW_ACTION_DROP) ? "drop" : "pass");
        } else {
            f->flags |= FLOW_ACTION_PASS;
            SCLogDebug("setting flow action pass");
        }
 
        // TODO firewall drop:flow should override FLOW_ACTION_PASS
    } else if (action & (ACTION_DROP | ACTION_REJECT_ANY)) {
        /* drop:flow from TD rules will override a accept:flow from
         * firewall rules. */
        if (f->flags & FLOW_ACTION_ACCEPT) {
            f->flags &= ~(FLOW_ACTION_ACCEPT | FLOW_ACTION_BY_FIREWALL);
            f->flags |= FLOW_ACTION_DROP;
            if (fw_rule)
                f->flags |= FLOW_ACTION_BY_FIREWALL;
            SCLogDebug("replaced FLOW_ACTION_ACCEPT with FLOW_ACTION_DROP");
        }
        if (f->flags & (FLOW_ACTION_DROP | FLOW_ACTION_PASS)) {
            /* drop or pass already set. First to set wins. */
            SCLogDebug("not setting %s flow already set to %s",
                    (action & ACTION_PASS) ? "pass" : "drop",
                    (f->flags & FLOW_ACTION_DROP) ? "drop" : "pass");
        } else {
            f->flags |= FLOW_ACTION_DROP;
            SCLogDebug("setting flow action drop");
        }
    }
 
    if (fw_rule) {
        f->flags |= FLOW_ACTION_BY_FIREWALL;
    }
}
 
/** \brief Apply action(s) and Set 'drop' sig info,
 *         if applicable
 *  \param p packet
 *  \param s signature -- for id, sig pointer, not actions
 *  \param pa packet alert struct -- match, including actions after thresholding (rate_filter) */
static void PacketApplySignatureActions(Packet *p, const Signature *s, const PacketAlert *pa)
{
    SCLogDebug("packet %" PRIu64 ", sid %u: action %02x alert_flags %02x", PcapPacketCntGet(p),
            s->id, pa->action, pa->flags);
 
    const bool is_fw_rule = s->flags & SIG_FLAG_FIREWALL ? true : false;
    /* REJECT also sets ACTION_DROP, just make it more visible with this check */
    if (pa->action & ACTION_DROP_REJECT) {
        uint8_t drop_reason = is_fw_rule ? PKT_DROP_REASON_FW_RULES : PKT_DROP_REASON_RULES;
        if (is_fw_rule) {
            if (s->detect_table == DETECT_TABLE_PACKET_PRE_STREAM) {
                drop_reason = PKT_DROP_REASON_FW_STREAM_PRE_HOOK;
            } else if (s->detect_table == DETECT_TABLE_PACKET_PRE_FLOW) {
                drop_reason = PKT_DROP_REASON_FW_FLOW_PRE_HOOK;
            }
        }
        /* PacketDrop will update the packet action, too */
        PacketDrop(p, pa->action,
                (pa->flags & PACKET_ALERT_FLAG_RATE_FILTER_MODIFIED)
                        ? PKT_DROP_REASON_RULES_THRESHOLD
                        : drop_reason);
        SCLogDebug("[packet %p][DROP sid %u]", p, s->id);
 
        if (p->alerts.drop.action == 0) {
            p->alerts.drop.iid = s->iid;
            p->alerts.drop.action = pa->action;
            p->alerts.drop.s = (Signature *)s;
        }
        if ((p->flow != NULL) && (pa->flags & PACKET_ALERT_FLAG_APPLY_ACTION_TO_FLOW)) {
            RuleActionToFlow(pa->action, p->flow, is_fw_rule);
        }
 
        DEBUG_VALIDATE_BUG_ON(!PacketCheckAction(p, ACTION_DROP));
    } else {
        if (pa->action & ACTION_ACCEPT) {
            const enum ActionScope as = pa->s->action_scope;
            SCLogDebug("packet %" PRIu64 ": ACCEPT %u as:%u flags:%02x", PcapPacketCntGet(p), s->id,
                    as, pa->flags);
            if (as == ACTION_SCOPE_PACKET || as == ACTION_SCOPE_FLOW ||
                    (pa->flags & PACKET_ALERT_FLAG_APPLY_ACTION_TO_PACKET)) {
                SCLogDebug("packet %" PRIu64 ": sid:%u ACCEPT", PcapPacketCntGet(p), s->id);
                p->action |= ACTION_ACCEPT;
            }
        } else if (pa->action & (ACTION_ALERT | ACTION_CONFIG)) {
            // nothing to set in the packet
        } else if (pa->action & ACTION_PASS) {
            SCLogDebug("[packet %p][PASS sid %u]", p, s->id);
            // nothing to set in the packet
        } else if (pa->action != 0) {
            DEBUG_VALIDATE_BUG_ON(1); // should be unreachable
        }
 
        if ((pa->action & (ACTION_PASS | ACTION_ACCEPT)) && (p->flow != NULL) &&
                (pa->flags & PACKET_ALERT_FLAG_APPLY_ACTION_TO_FLOW)) {
            RuleActionToFlow(pa->action, p->flow, is_fw_rule);
        }
    }
}
 
void AlertQueueInit(DetectEngineThreadCtx *det_ctx)
{
    det_ctx->alert_queue_size = 0;
    det_ctx->alert_queue = SCCalloc(packet_alert_max, sizeof(PacketAlert));
    if (det_ctx->alert_queue == NULL) {
        FatalError("failed to allocate %" PRIu64 " bytes for the alert queue",
                (uint64_t)(packet_alert_max * sizeof(PacketAlert)));
    }
    det_ctx->alert_queue_capacity = packet_alert_max;
    SCLogDebug("alert queue initialized to %u elements (%" PRIu64 " bytes)", packet_alert_max,
            (uint64_t)(packet_alert_max * sizeof(PacketAlert)));
}
 
void AlertQueueFree(DetectEngineThreadCtx *det_ctx)
{
    SCFree(det_ctx->alert_queue);
    det_ctx->alert_queue_capacity = 0;
}
 
static inline uint16_t AlertQueueExpandDo(DetectEngineThreadCtx *det_ctx, uint16_t new_cap)
{
    DEBUG_VALIDATE_BUG_ON(det_ctx->alert_queue_capacity >= new_cap);
 
    void *tmp_queue = SCRealloc(det_ctx->alert_queue, new_cap * sizeof(PacketAlert));
    if (unlikely(tmp_queue == NULL)) {
        /* queue capacity didn't change */
        return det_ctx->alert_queue_capacity;
    }
    det_ctx->alert_queue = tmp_queue;
    det_ctx->alert_queue_capacity = new_cap;
    SCLogDebug("Alert queue size expanded: %u elements, bytes: %" PRIuMAX "",
            det_ctx->alert_queue_capacity, (uintmax_t)(new_cap * sizeof(PacketAlert)));
    return new_cap;
}
 
/** \internal
 * \retval the new capacity
 */
static uint16_t AlertQueueExpand(DetectEngineThreadCtx *det_ctx)
{
#ifdef QA_SIMULATION
    if (unlikely(g_eps_is_alert_queue_fail_mode))
        return det_ctx->alert_queue_capacity;
#endif
    if (det_ctx->alert_queue_capacity == UINT16_MAX) {
        return det_ctx->alert_queue_capacity;
    }
 
    uint16_t new_cap;
    if (det_ctx->alert_queue_capacity > (UINT16_MAX / 2)) {
        new_cap = UINT16_MAX;
    } else {
        new_cap = det_ctx->alert_queue_capacity * 2;
    }
    return AlertQueueExpandDo(det_ctx, new_cap);
}
 
static inline int PacketAlertSetContext(
        DetectEngineThreadCtx *det_ctx, PacketAlert *pa, const Signature *s)
{
    pa->json_info = NULL;
    if (det_ctx->json_content_len) {
        /* We have some JSON attached in the current detection so let's try
           to see if some need to be used for current signature. */
        struct PacketContextData *current_json = NULL;
        for (uint8_t i = 0; i < det_ctx->json_content_len; i++) {
            if (s == det_ctx->json_content[i].id) {
                SCLogDebug("signature %p, content index %u", s, i);
                if (current_json == NULL) {
                    /* Allocate the first one */
                    current_json = SCCalloc(1, sizeof(struct PacketContextData));
                    if (current_json == NULL) {
                        /* Allocation error, let's return now */
                        return -1;
                    }
                    if (pa->json_info == NULL) {
                        /* If this is the first one, set it */
                        pa->json_info = current_json;
                    }
                    current_json->next = NULL;
                } else {
                    /* Allocate the next one */
                    struct PacketContextData *next_json =
                            SCCalloc(1, sizeof(struct PacketContextData));
                    if (next_json) {
                        current_json->next = next_json;
                        current_json = next_json;
                        current_json->next = NULL;
                    } else {
                        /* Allocation error, let's return now */
                        return -1;
                    }
                }
                current_json->json_string = SCStrdup(det_ctx->json_content[i].json_content);
                if (current_json->json_string == NULL) {
                    return -1;
                }
                SCLogDebug("json content %u, value '%s' (%p)", (unsigned int)i,
                        current_json->json_string, s);
            }
        }
    }
 
    return 0;
}
 
/** \internal
 */
static inline PacketAlert PacketAlertSet(DetectEngineThreadCtx *det_ctx, const Signature *s,
        uint64_t tx_id, const uint8_t sub_state, uint8_t alert_flags)
{
    PacketAlert pa;
    pa.iid = s->iid;
    pa.action = s->action;
    pa.s = (Signature *)s;
    pa.flags = alert_flags;
    /* Set tx_id if the frame has it */
    pa.tx_id = tx_id;
    pa.sub_state = sub_state;
    pa.frame_id = (alert_flags & PACKET_ALERT_FLAG_FRAME) ? det_ctx->frame_id : 0;
    PacketAlertSetContext(det_ctx, &pa, s);
    return pa;
}
 
/**
 * \brief Append signature to local packet alert queue for later preprocessing
 */
static void AlertQueueAppend(DetectEngineThreadCtx *det_ctx, const Signature *s, Packet *p,
        const uint64_t tx_id, const uint8_t sub_state, uint8_t alert_flags)
{
    /* first time we see a drop action signature, set that in the packet */
    /* we do that even before inserting into the queue, so we save it even if appending fails */
    if (p->alerts.drop.action == 0 && s->action & ACTION_DROP) {
        p->alerts.drop = PacketAlertSet(det_ctx, s, tx_id, sub_state, alert_flags);
        SCLogDebug("sid %u: set PacketAlert drop action. s->iid %" PRIu32 "", s->id, s->iid);
    }
 
    uint16_t pos = det_ctx->alert_queue_size;
    if (pos == det_ctx->alert_queue_capacity) {
        /* we must grow the alert queue */
        if (pos == AlertQueueExpand(det_ctx)) {
            /* this means we failed to expand the queue */
            p->alerts.discarded++;
            return;
        }
    }
    det_ctx->alert_queue[pos] = PacketAlertSet(det_ctx, s, tx_id, sub_state, alert_flags);
 
    SCLogDebug("packet %" PRIu64 ": appending sid %" PRIu32 ", s->iid %" PRIu32 " to alert queue",
            PcapPacketCntGet(p), s->id, s->iid);
    det_ctx->alert_queue_size++;
}
 
/**
 * \brief Append signature to local packet alert queue for later preprocessing
 */
void AlertQueueAppendAppTx(DetectEngineThreadCtx *det_ctx, const Signature *s, Packet *p,
        uint64_t tx_id, uint8_t sub_state, uint8_t alert_flags)
{
    alert_flags |= (PACKET_ALERT_FLAG_TX | PACKET_ALERT_FLAG_STATE_MATCH);
    return AlertQueueAppend(det_ctx, s, p, tx_id, sub_state, alert_flags);
}
 
/**
 * \brief Append signature to local packet alert queue for later preprocessing
 * This does not automatically set PACKET_ALERT_FLAG_STATE_MATCH as this
 * comes from the packet alert path.
 */
void AlertQueueAppendAppTxFromPacket(DetectEngineThreadCtx *det_ctx, const Signature *s, Packet *p,
        uint64_t tx_id, const uint8_t sub_state, uint8_t alert_flags)
{
    alert_flags |= PACKET_ALERT_FLAG_TX;
    return AlertQueueAppend(det_ctx, s, p, tx_id, sub_state, alert_flags);
}
 
/**
 * \brief Append signature to local packet alert queue for later preprocessing
 */
void AlertQueueAppendPacket(
        DetectEngineThreadCtx *det_ctx, const Signature *s, Packet *p, uint8_t alert_flags)
{
    return AlertQueueAppend(det_ctx, s, p, PACKET_ALERT_NOTX, 0, alert_flags);
}
 
/** \internal
 * \brief sort helper for sorting alerts by priority
 *
 * Sorting is done first based on num and then using tx_id, if nums are equal.
 * The Signature::num field is set based on internal priority. Higher priority
 * rules have lower nums.
 */
static int AlertQueueSortHelperFirewall(const void *a, const void *b)
{
    const PacketAlert *pa0 = a;
    const PacketAlert *pa1 = b;
    if (pa0->s->detect_table == pa1->s->detect_table) {
        if (pa1->iid == pa0->iid) {
            if (pa1->tx_id == PACKET_ALERT_NOTX) {
                return -1;
            } else if (pa0->tx_id == PACKET_ALERT_NOTX) {
                return 1;
            }
            return pa0->tx_id < pa1->tx_id ? 1 : -1;
        } else {
            return pa0->iid < pa1->iid ? -1 : 1;
        }
    }
    return pa0->s->detect_table < pa1->s->detect_table ? -1 : 1;
}
 
static int AlertQueueSortHelper(const void *a, const void *b)
{
    const PacketAlert *pa0 = a;
    const PacketAlert *pa1 = b;
    if (pa1->iid == pa0->iid) {
        if (pa1->tx_id == PACKET_ALERT_NOTX) {
            return -1;
        } else if (pa0->tx_id == PACKET_ALERT_NOTX) {
            return 1;
        }
        return pa0->tx_id < pa1->tx_id ? 1 : -1;
    } else {
        return pa0->iid < pa1->iid ? -1 : 1;
    }
}
 
/** \internal
 * \brief Check if Signature action should be applied to flow and apply
 *
 */
static inline void FlowApplySignatureActions(
        Packet *p, PacketAlert *pa, const Signature *s, uint8_t alert_flags)
{
    /* For DROP and PASS sigs we need to apply the action to the flow if
     * - sig is IP or PD only
     * - match is in applayer
     * - match is in stream */
    if (pa->action & (ACTION_DROP | ACTION_PASS | ACTION_ACCEPT)) {
        DEBUG_VALIDATE_BUG_ON(s->type == SIG_TYPE_NOT_SET);
        DEBUG_VALIDATE_BUG_ON(s->type == SIG_TYPE_MAX);
 
        if (s->action_scope == ACTION_SCOPE_FLOW) {
            pa->flags |= PACKET_ALERT_FLAG_APPLY_ACTION_TO_FLOW;
        } else if (s->action_scope == ACTION_SCOPE_AUTO) {
            enum SignaturePropertyFlowAction flow_action =
                    signature_properties[s->type].flow_action;
            if (flow_action == SIG_PROP_FLOW_ACTION_FLOW) {
                pa->flags |= PACKET_ALERT_FLAG_APPLY_ACTION_TO_FLOW;
            } else if (flow_action == SIG_PROP_FLOW_ACTION_FLOW_IF_STATEFUL) {
                if (pa->flags & (PACKET_ALERT_FLAG_STATE_MATCH | PACKET_ALERT_FLAG_STREAM_MATCH)) {
                    pa->flags |= PACKET_ALERT_FLAG_APPLY_ACTION_TO_FLOW;
                }
            }
        }
 
        if (pa->flags & PACKET_ALERT_FLAG_APPLY_ACTION_TO_FLOW) {
            SCLogDebug("packet %" PRIu64 " sid %u action %02x alert_flags %02x (set "
                       "PACKET_ALERT_FLAG_APPLY_ACTION_TO_FLOW)",
                    PcapPacketCntGet(p), s->id, s->action, pa->flags);
        }
    }
}
 
/** \internal
 * \brief handle immediate actions for a firewall rule match
 *
 * Delayed action (accept) is handled after TD has also run, as TD drop
 * can overrule a FW accept. So returning `accept` here means "will accept if TD agrees".
 *
 * \retval pol firewall policy with action that is (drop) or should possibly be (accept)
 * applied to the packet and flow.
 */
static struct DetectFirewallPolicy HandleFirewallRule(
        const DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, Packet *p, PacketAlert *pa)
{
    const Signature *s = pa->s;
    struct DetectFirewallPolicy pol = { .action = 0, .action_scope = 0 };
    int res = PacketAlertHandle(de_ctx, det_ctx, s, p, pa);
    SCLogDebug("packet %" PRIu64 ": fw sid %u: res %d", PcapPacketCntGet(p), s->id, res);
    if (res > 0) {
        /* Now, if we have an alert, we have to check if we want
         * to tag this session or src/dst host */
        if (s->sm_arrays[DETECT_SM_LIST_TMATCH] != NULL) {
            KEYWORD_PROFILING_SET_LIST(det_ctx, DETECT_SM_LIST_TMATCH);
            SigMatchData *smd = s->sm_arrays[DETECT_SM_LIST_TMATCH];
            while (1) {
                /* tags are set only for alerts */
                KEYWORD_PROFILING_START;
                sigmatch_table[smd->type].Match(det_ctx, p, (Signature *)s, smd->ctx);
                KEYWORD_PROFILING_END(det_ctx, smd->type, 1);
                if (smd->is_last)
                    break;
                smd++;
            }
        }
        /* if this is a terminating action, pass the action to the caller. */
        if (s->action_scope != ACTION_SCOPE_HOOK ||
                pa->flags & PACKET_ALERT_FLAG_APPLY_ACTION_TO_PACKET) {
            pol.action = s->action;
            pol.action_scope = s->action_scope;
            if (pol.action & ACTION_DROP) {
                uint8_t drop_reason = PKT_DROP_REASON_FW_RULES;
                if (s->detect_table == DETECT_TABLE_PACKET_PRE_STREAM) {
                    drop_reason = PKT_DROP_REASON_FW_STREAM_PRE_HOOK;
                } else if (s->detect_table == DETECT_TABLE_PACKET_PRE_FLOW) {
                    drop_reason = PKT_DROP_REASON_FW_FLOW_PRE_HOOK;
                }
                PacketDrop(p, pol.action, drop_reason);
                if (p->flow && pol.action_scope == ACTION_SCOPE_FLOW) {
                    p->flow->flags |= FLOW_ACTION_DROP | FLOW_ACTION_BY_FIREWALL;
                    SCLogDebug("packet %" PRIu64 ": FLOW_ACTION_DROP set by firewall by sid %u",
                            PcapPacketCntGet(p), s->id);
                }
            }
            if (pol.action & ACTION_PASS) {
                if (p->flow && pol.action_scope == ACTION_SCOPE_FLOW) {
                    p->flow->flags |= FLOW_ACTION_PASS;
                    SCLogDebug("packet %" PRIu64 ": FLOW_ACTION_PASS set by firewall by sid %u",
                            PcapPacketCntGet(p), s->id);
                }
            }
        }
        /* add the alert for logging if required. */
        if (s->action & ACTION_ALERT) {
            if (p->alerts.cnt < packet_alert_max) {
                p->alerts.alerts[p->alerts.cnt++] = *pa;
            } else {
                p->alerts.firewall_discarded++;
            }
        }
    }
    return pol;
}
 
/*
 * Queue order after sorting:
 *
 * Firewall use case: rules are sorted by Signature::detect_table, Signature::iid (which reflects
 * order in the rule file(s)) This means:
 * - pre_flow
 * - pre_stream
 * - packet:filter (firewall)
 * - packet:td (IDS/IPS rules)
 * - app:filter (firewall)
 * - app:td (IDS/IPS rules)
 *
 * Firewall DROPs are immediate.
 * Firewall ACCEPTs depend on TD not dropping.
 * Firewall rules are not affected by PASS.
 * TD rules are affected by PASS, both set by Firewall and TD rules.
 *
 * Non-Firewall use case: rules are sorted by Signature::iid (which reflect order based on flowbits,
 * action-order, priority, etc)
 */
static inline void PacketAlertFinalizeProcessQueue(
        const DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, Packet *p)
{
    const bool have_fw_rules = EngineModeIsFirewall();
 
    if (det_ctx->alert_queue_size > 1) {
        /* sort the alert queue before thresholding and appending to Packet */
        qsort(det_ctx->alert_queue, det_ctx->alert_queue_size, sizeof(PacketAlert),
                have_fw_rules ? AlertQueueSortHelperFirewall : AlertQueueSortHelper);
    }
 
    bool alerted = false;
    bool dropped = false;
    bool skip_td = false;
    bool skip_fw = false;
    bool fw_accept_packet = false; // same as skip_fw?
    bool fw_accept_flow = false;
 
#ifdef DEBUG
    SCLogDebug("packet %" PRIu64 ": starting alert event queue", PcapPacketCntGet(p));
    for (uint16_t x = 0; x < det_ctx->alert_queue_size; x++) {
        const PacketAlert *pa = &det_ctx->alert_queue[x];
        const Signature *s = pa->s;
        SCLogDebug("(list) %s sid %u: action %02x scope %u iid %u detect_table %u",
                (s->flags & SIG_FLAG_FIREWALL) ? "fw" : "td", s->id, s->action, s->action_scope,
                s->iid, s->detect_table);
    }
#endif /* DEBUG */
    uint8_t skip_table_id = 0;
    bool skip_table = false;
    for (uint16_t i = 0; i < det_ctx->alert_queue_size; i++) {
        PacketAlert *pa = &det_ctx->alert_queue[i];
        const Signature *s = pa->s;
 
        if (s->flags & SIG_FLAG_FIREWALL) {
            if (skip_fw) {
                continue;
            }
            /* skip for this table, but not for later. Mostly for showing
             * alerts for both packet:filter and app:filter together. */
            if (skip_table) {
                if (s->detect_table <= skip_table_id)
                    continue;
                skip_table = false;
            }
 
            if (dropped) {
                SCLogDebug("Skipping firewall signature after a drop.");
                continue;
            }
 
            const uint16_t pre_alert_cnt = p->alerts.cnt;
            struct DetectFirewallPolicy pol = HandleFirewallRule(de_ctx, det_ctx, p, pa);
            /* drop is immediate */
            if (pol.action & ACTION_DROP) {
                dropped = true;
            } else if (pol.action & ACTION_ACCEPT) {
                SCLogDebug("fw sid %u setting skip_fw for action %02x scope %s", s->id, pol.action,
                        ActionScopeToString(pol.action_scope));
                /* see if we want to skip other alerts for this table */
                if (pol.action_scope == ACTION_SCOPE_HOOK) {
                    skip_table_id = s->detect_table;
                    skip_table = true;
                } else {
                    skip_fw = true;
                }
                fw_accept_packet = true;
                if (pol.action_scope == ACTION_SCOPE_FLOW)
                    fw_accept_flow = true;
            }
            if (pol.action & ACTION_PASS) {
                skip_td = true;
            }
            if (pre_alert_cnt < p->alerts.cnt)
                alerted = true;
            if (dropped)
                goto fw_dropped;
 
            continue;
        }
 
        SCLogDebug("sid: %u, action %02x, firewall? %s", s->id, pa->action,
                BOOL2STR(s->flags & SIG_FLAG_FIREWALL));
 
        /* if a firewall rule told us to skip, we don't count the skipped
         * alerts. */
        if (have_fw_rules && skip_td) {
            continue;
        }
 
        int res = PacketAlertHandle(de_ctx, det_ctx, s, p, pa);
        SCLogDebug("sid %u: res %d", pa->s->id, res);
        if (res > 0) {
            /* Now, if we have an alert, we have to check if we want
             * to tag this session or src/dst host */
            if (s->sm_arrays[DETECT_SM_LIST_TMATCH] != NULL) {
                KEYWORD_PROFILING_SET_LIST(det_ctx, DETECT_SM_LIST_TMATCH);
                SigMatchData *smd = s->sm_arrays[DETECT_SM_LIST_TMATCH];
                while (1) {
                    /* tags are set only for alerts */
                    KEYWORD_PROFILING_START;
                    sigmatch_table[smd->type].Match(det_ctx, p, (Signature *)s, smd->ctx);
                    KEYWORD_PROFILING_END(det_ctx, smd->type, 1);
                    if (smd->is_last)
                        break;
                    smd++;
                }
            }
 
            bool skip_action_set = false;
            if ((p->action & (ACTION_DROP | ACTION_ACCEPT)) != 0) {
                if (p->action & ACTION_DROP) {
                    if (pa->action & (ACTION_PASS | ACTION_ACCEPT)) {
                        skip_action_set = true;
                    }
                } else {
                    if (pa->action & (ACTION_DROP)) {
                        skip_action_set = true;
                    }
                }
            }
            SCLogDebug("packet %" PRIu64 ": i:%u sid:%u skip_action_set %s", PcapPacketCntGet(p), i,
                    s->id, BOOL2STR(skip_action_set));
            if (!skip_action_set) {
                /* set actions on the flow */
                FlowApplySignatureActions(p, pa, s, pa->flags);
 
                SCLogDebug("sid %u: action %02x (DROP %s, PASS %s)", pa->s->id, pa->action,
                        BOOL2STR(pa->action & ACTION_DROP), BOOL2STR(pa->action & ACTION_PASS));
 
                /* set actions on packet */
                PacketApplySignatureActions(p, s, pa);
            }
        }
 
        /* Thresholding removes this alert */
        if (res == 0 || res == 2 || (s->action & (ACTION_ALERT | ACTION_PASS)) == 0) {
            SCLogDebug("sid:%u: skipping alert because of thresholding (res=%d) or NOALERT (%02x)",
                    s->id, res, s->action);
            /* we will not copy this to the AlertQueue */
            p->alerts.suppressed++;
        } else if (p->alerts.cnt < packet_alert_max) {
            p->alerts.alerts[p->alerts.cnt++] = *pa;
            SCLogDebug("appending sid %" PRIu32 " alert to Packet::alerts at pos %u; action:%02x",
                    s->id, i, pa->action);
 
            if (pa->action & ACTION_ALERT) {
                alerted = true;
            }
            /* pass with alert, we're done. Alert is logged. */
            if (pa->action & ACTION_PASS) {
                SCLogDebug("sid:%u: is a pass rule, so break out of loop", s->id);
                if (!have_fw_rules)
                    break;
                SCLogDebug("skipping td");
                skip_td = true;
                continue;
            }
        } else {
            p->alerts.discarded++;
        }
 
        if (s->action & ACTION_DROP) {
            dropped = true;
        }
    }
 
fw_dropped:
    /* after threat detection has been handled, see if the fw intended to accept (drop is handled
     * immediately by the fw), as fw accept can be overruled by td drop. */
    if (have_fw_rules) {
        if (p->action & ACTION_DROP) {
            SCLogDebug("packet %" PRIu64 ": dropped by TD", PcapPacketCntGet(p));
        } else if (fw_accept_packet) {
            p->action |= ACTION_ACCEPT;
            if (p->flow && fw_accept_flow) {
                p->flow->flags |= FLOW_ACTION_ACCEPT;
                SCLogDebug("packet %" PRIu64 ": FLOW_ACTION_ACCEPT set from firewall",
                        PcapPacketCntGet(p));
            }
        }
    }
 
    /* Set flag on flow to indicate that it has alerts. We use the bool to
     * exclude pass-only entries in `Packet::alerts` */
    if (alerted && p->flow != NULL) {
        if (!FlowHasAlerts(p->flow)) {
            FlowSetHasAlertsFlag(p->flow);
            p->flags |= PKT_FIRST_ALERTS;
        }
    }
 
    /* Notify capture layer about packets with real alerts (not pass-only),
     * so capture impl can update per-capture context (e.g. pcap-file alert counts). */
    if (alerted) {
        CaptureHooksOnPacketWithAlerts(p);
    }
}
 
/**
 * \brief Check the threshold of the sigs that match, set actions, break on pass action
 *        This function iterate the packet alerts array, removing those that didn't match
 *        the threshold, and those that match after a signature with the action "pass".
 *        The array is sorted by action priority/order
 * \param de_ctx detection engine context
 * \param det_ctx detection engine thread context
 * \param p pointer to the packet
 */
void PacketAlertFinalize(const DetectEngineCtx *de_ctx, DetectEngineThreadCtx *det_ctx, Packet *p)
{
    SCEnter();
 
    if (det_ctx->alert_queue_size > 0) {
        PacketAlertFinalizeProcessQueue(de_ctx, det_ctx, p);
        if (det_ctx->json_content_len)
            p->flags |= PKT_ALERT_CTX_USED;
    }
 
    /* At this point, we should have all the new alerts. Now check the tag
     * keyword context for sessions and hosts */
    if (!(p->flags & PKT_PSEUDO_STREAM_END))
        TagHandlePacket(de_ctx, det_ctx, p);
}
 
#ifdef UNITTESTS
#include "tests/detect-engine-alert.c"
#endif