suricata
detect-frame.c
Go to the documentation of this file.
1 /* Copyright (C) 2021-2022 Open Information Security Foundation
2  *
3  * You can copy, redistribute or modify this Program under the terms of
4  * the GNU General Public License version 2 as published by the Free
5  * Software Foundation.
6  *
7  * This program is distributed in the hope that it will be useful,
8  * but WITHOUT ANY WARRANTY; without even the implied warranty of
9  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10  * GNU General Public License for more details.
11  *
12  * You should have received a copy of the GNU General Public License
13  * version 2 along with this program; if not, write to the Free Software
14  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
15  * 02110-1301, USA.
16  */
17 
18 /**
19  * \file
20  */
21 
22 #include "suricata-common.h"
23 #include "threads.h"
24 #include "decode.h"
25 #include "detect.h"
26 
27 #include "app-layer-frames.h"
28 #include "app-layer-parser.h"
29 
30 #include "detect-parse.h"
31 #include "detect-engine.h"
32 #include "detect-engine-buffer.h"
33 #include "detect-engine-mpm.h"
35 #include "detect-content.h"
37 #include "detect-frame.h"
38 
39 #include "flow.h"
40 #include "flow-util.h"
41 #include "flow-var.h"
42 
43 #include "conf.h"
44 #include "conf-yaml-loader.h"
45 
46 #include "util-debug.h"
47 #include "util-unittest.h"
48 #include "util-spm.h"
49 #include "util-print.h"
50 
51 static int DetectFrameSetup(DetectEngineCtx *, Signature *, const char *);
52 
53 /**
54  * \brief this function setup the sticky buffer used in the rule
55  *
56  * \param de_ctx Pointer to the Detection Engine Context
57  * \param s Pointer to the Signature to which the current keyword belongs
58  * \param str The frame name. Can be short name 'pdu' or full name 'sip.pdu'
59  *
60  * \retval 0 On success
61  * \retval -1 On failure
62  */
63 static int DetectFrameSetup(DetectEngineCtx *de_ctx, Signature *s, const char *str)
64 {
65  char value[256] = "";
66  strlcpy(value, str, sizeof(value));
67  char buffer_name[512] = ""; // for registering in detect API we always need <proto>.<frame>.
68 
69  const bool is_tcp = DetectProtoContainsProto(&s->proto, IPPROTO_TCP);
70  const bool is_udp = DetectProtoContainsProto(&s->proto, IPPROTO_UDP);
71  if (!(is_tcp || is_udp)) {
72  SCLogError("'frame' keyword only supported for TCP and UDP");
73  return -1;
74  }
75 
76  char *dot = strchr(value, '.');
77  if (dot != NULL)
78  *dot++ = '\0';
79  const char *val = dot ? dot : value;
80  const char *proto = dot ? value : NULL;
81 
82  bool is_short = false;
83  AppProto keyword_alproto = ALPROTO_UNKNOWN;
84  AppProto rule_alproto = s->alproto;
85 
86  if (proto != NULL) {
87  keyword_alproto = StringToAppProto(proto);
88  if (!AppProtoIsValid(keyword_alproto)) {
89  is_short = true;
90  keyword_alproto = rule_alproto;
91  }
92  } else {
93  is_short = true;
94  keyword_alproto = rule_alproto;
95  }
96 
97  if (is_short && rule_alproto == ALPROTO_UNKNOWN) {
98  SCLogError("rule protocol unknown, can't use shorthand notation for frame '%s'", str);
99  return -1;
100  } else if (rule_alproto == ALPROTO_UNKNOWN) {
101  if (DetectSignatureSetAppProto(s, keyword_alproto) < 0)
102  return -1;
103  } else if (!AppProtoEquals(rule_alproto, keyword_alproto)) {
104  SCLogError("frame '%s' protocol '%s' mismatch with rule protocol '%s'", str,
105  AppProtoToString(keyword_alproto), AppProtoToString(s->alproto));
106  return -1;
107  }
108 
109  const char *frame_str = is_short ? str : val;
110  int raw_frame_type = -1;
111  if (is_tcp) {
112  if (strcmp(frame_str, "stream") == 0) {
113  raw_frame_type = FRAME_STREAM_TYPE;
114  } else {
115  raw_frame_type =
116  AppLayerParserGetFrameIdByName(IPPROTO_TCP, keyword_alproto, frame_str);
117  }
118  }
119  if (is_udp && raw_frame_type < 0)
120  raw_frame_type = AppLayerParserGetFrameIdByName(IPPROTO_UDP, keyword_alproto, frame_str);
121  if (raw_frame_type < 0) {
122  SCLogError("unknown frame '%s' for protocol '%s'", frame_str, proto);
123  return -1;
124  }
125  BUG_ON(raw_frame_type > UINT8_MAX);
126 
127  if (is_short) {
128  snprintf(buffer_name, sizeof(buffer_name), "%s.%s", AppProtoToString(s->alproto), str);
129  SCLogDebug("short name: %s", buffer_name);
130  } else {
131  strlcpy(buffer_name, str, sizeof(buffer_name));
132  SCLogDebug("long name: %s", buffer_name);
133  }
134 
135  uint8_t frame_type = (uint8_t)raw_frame_type;
136  /* TODO we can have TS and TC specific frames */
137  const int buffer_id = DetectEngineBufferTypeRegisterWithFrameEngines(de_ctx, buffer_name,
138  SIG_FLAG_TOSERVER | SIG_FLAG_TOCLIENT, keyword_alproto, frame_type);
139  if (buffer_id < 0)
140  return -1;
141 
142  if (SCDetectBufferSetActiveList(de_ctx, s, buffer_id) < 0)
143  return -1;
144 
145  FrameConfigEnable(keyword_alproto, frame_type);
146  return 0;
147 }
148 
149 #ifdef UNITTESTS
150 
151 static int DetectFrameTestBadRules(void)
152 {
155 
156  const char *sigs[] = {
157  "alert tcp-pkt any any -> any any (frame:tls.pdu; content:\"a\"; sid:1;)",
158  "alert udp any any -> any any (frame:tls.pdu; content:\"a\"; sid:2;)",
159  "alert smb any any -> any any (frame:tls.pdu; content:\"a\"; sid:3;)",
160  "alert tcp any any -> any any (frame:tls; content:\"a\"; sid:4;)",
161  "alert tls any any -> any any (content:\"abc\"; frame:tls.pdu; content:\"a\"; sid:5;)",
162  "alert tls any any -> any any (tls.version:1.0; frame:tls.pdu; content:\"a\"; sid:6;)",
163  "alert tls any any -> any any (frame:smb1.pdu; content:\"a\"; sid:7;)",
164  NULL,
165  };
166 
167  const char **sig = sigs;
168  while (*sig) {
169  SCLogDebug("sig %s", *sig);
171  FAIL_IF_NOT_NULL(s);
172  sig++;
173  }
174 
176  PASS;
177 }
178 
179 static void DetectFrameRegisterTests(void)
180 {
181  UtRegisterTest("DetectFrameTestBadRules", DetectFrameTestBadRules);
182 }
183 #endif
184 
185 /**
186  * \brief Registration function for keyword: ja3_hash
187  */
189 {
190  sigmatch_table[DETECT_FRAME].name = "frame";
191  sigmatch_table[DETECT_FRAME].desc = "sticky buffer for inspecting app-layer frames";
192  sigmatch_table[DETECT_FRAME].Setup = DetectFrameSetup;
194 #ifdef UNITTESTS
195  sigmatch_table[DETECT_FRAME].RegisterTests = DetectFrameRegisterTests;
196 #endif
197 }
DetectSignatureSetAppProto
int DetectSignatureSetAppProto(Signature *s, AppProto alproto)
Definition: detect-parse.c:2313
detect-content.h
detect-engine.h
FAIL_IF_NULL
#define FAIL_IF_NULL(expr)
Fail a test if expression evaluates to NULL.
Definition: util-unittest.h:89
SIGMATCH_INFO_STICKY_BUFFER
#define SIGMATCH_INFO_STICKY_BUFFER
Definition: detect.h:1645
SigTableElmt_::desc
const char * desc
Definition: detect.h:1430
sigmatch_table
SigTableElmt * sigmatch_table
Definition: detect-parse.c:155
flow-util.h
SigTableElmt_::name
const char * name
Definition: detect.h:1428
UtRegisterTest
void UtRegisterTest(const char *name, int(*TestFn)(void))
Register unit test.
Definition: util-unittest.c:103
Signature_::alproto
AppProto alproto
Definition: detect.h:675
SCLogDebug
#define SCLogDebug(...)
Definition: util-debug.h:269
AppProto
uint16_t AppProto
Definition: app-layer-protos.h:85
threads.h
AppProtoToString
const char * AppProtoToString(AppProto alproto)
Maps the ALPROTO_*, to its string equivalent.
Definition: app-layer-protos.c:40
SigTableElmt_::flags
uint16_t flags
Definition: detect.h:1422
DetectEngineCtx_
main detection engine ctx
Definition: detect.h:931
DetectEngineCtxFree
void DetectEngineCtxFree(DetectEngineCtx *)
Free a DetectEngineCtx::
Definition: detect-engine.c:2674
DETECT_FRAME
@ DETECT_FRAME
Definition: detect-engine-register.h:126
SCDetectBufferSetActiveList
int SCDetectBufferSetActiveList(DetectEngineCtx *de_ctx, Signature *s, const int list)
Definition: detect-engine-buffer.c:29
proto
uint8_t proto
Definition: decode-template.h:0
DetectEngineAppendSig
Signature * DetectEngineAppendSig(DetectEngineCtx *, const char *)
Parse and append a Signature into the Detection Engine Context signature list.
Definition: detect-parse.c:3439
SIG_FLAG_TOCLIENT
#define SIG_FLAG_TOCLIENT
Definition: detect.h:271
SigTableElmt_::Setup
int(* Setup)(DetectEngineCtx *, Signature *, const char *)
Definition: detect.h:1413
detect-engine-prefilter.h
util-unittest.h
strlcpy
size_t strlcpy(char *dst, const char *src, size_t siz)
Definition: util-strlcpyu.c:43
SIG_FLAG_TOSERVER
#define SIG_FLAG_TOSERVER
Definition: detect.h:270
decode.h
FAIL_IF_NOT_NULL
#define FAIL_IF_NOT_NULL(expr)
Fail a test if expression evaluates to non-NULL.
Definition: util-unittest.h:96
util-debug.h
PASS
#define PASS
Pass the test.
Definition: util-unittest.h:105
de_ctx
DetectEngineCtx * de_ctx
Definition: fuzz_siginit.c:18
StringToAppProto
AppProto StringToAppProto(const char *proto_name)
Maps a string to its ALPROTO_* equivalent.
Definition: app-layer-protos.c:60
util-print.h
detect-engine-mpm.h
detect.h
app-layer-parser.h
BUG_ON
#define BUG_ON(x)
Definition: suricata-common.h:317
detect-frame.h
conf-yaml-loader.h
conf.h
detect-engine-content-inspection.h
DetectEngineBufferTypeRegisterWithFrameEngines
int DetectEngineBufferTypeRegisterWithFrameEngines(DetectEngineCtx *de_ctx, const char *name, const int direction, const AppProto alproto, const uint8_t frame_type)
Definition: detect-engine.c:1210
app-layer-frames.h
Signature_::proto
DetectProto proto
Definition: detect.h:689
suricata-common.h
AppLayerParserGetFrameIdByName
int AppLayerParserGetFrameIdByName(uint8_t ipproto, AppProto alproto, const char *name)
Definition: app-layer-parser.c:1626
util-spm.h
detect-engine-buffer.h
FRAME_STREAM_TYPE
#define FRAME_STREAM_TYPE
Definition: app-layer-frames.h:32
str
#define str(s)
Definition: suricata-common.h:308
SCLogError
#define SCLogError(...)
Macro used to log ERROR messages.
Definition: util-debug.h:261
detect-parse.h
Signature_
Signature container.
Definition: detect.h:670
FrameConfigEnable
void FrameConfigEnable(const AppProto p, const uint8_t type)
Definition: app-layer-frames.c:64
ALPROTO_UNKNOWN
@ ALPROTO_UNKNOWN
Definition: app-layer-protos.h:29
DetectEngineCtxInit
DetectEngineCtx * DetectEngineCtxInit(void)
Definition: detect-engine.c:2635
flow.h
flow-var.h
SigTableElmt_::RegisterTests
void(* RegisterTests)(void)
Definition: detect.h:1420
DetectProtoContainsProto
int DetectProtoContainsProto(const DetectProto *dp, int proto)
see if a DetectProto contains a certain proto
Definition: detect-engine-proto.c:135
DetectFrameRegister
void DetectFrameRegister(void)
Registration function for keyword: ja3_hash.
Definition: detect-frame.c:188